1519616 - Preview of Themes is visible on other items in Add-ons Manager (about:addons)

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/message/reply/question/etc.)]

Attachment: Screencast.mp4

STR:

1. Use some external Light Themes/Appearances/Personas not build in browser (like https://addons.mozilla.org/addon/virtualfox/ for example)
2. Open Add-ons Manager (about:addons)
3. Open Themes tab
4. Open external Light Themes/Appearances/Personas
5. Open other item
   and see that preview of Light Themes/Appearances/Personas is visible on other items

Comment 1

[David Durst [:ddurst]]

Assuming LWT, migration pending so wontfix.

Comment 2

[Mark Striemer [:mstriemer]]

This affects static themes as well, taking

Comment 3

[Mark Striemer [:mstriemer]]

Can reproduce on 65, but not 64.

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1519616 - Explicitly clear theme preview on details for non-themes r?aswan

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de208c99e477
Explicitly clear theme preview on details for non-themes r=aswan

Comment 6

[Mark Striemer [:mstriemer]]

Attachment: Bug 1519616 - Clear theme preview for themes that don't have previews r?aswan

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0aba112c5ad9
Clear theme preview for themes that don't have previews r=aswan

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance. The final Beta build is being created on Thursday.

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/de208c99e477
https://hg.mozilla.org/mozilla-central/rev/0aba112c5ad9

Comment 10

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/message/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 66.0a1 (2019-01-16), so I'm marking this bug as VERIFIED.
Thank you very much! \o/

Comment 11

[Mark Striemer [:mstriemer]]

Comment on attachment 9036678 [details]
Bug 1519616 - Explicitly clear theme preview on details for non-themes r?aswan

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1506987

User impact if declined: After viewing a theme detail page, its preview image will be shown on other detail pages.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: 1. View the detail page for a theme
2. View the detail page for a plugin or extension

Expected: There is no preview image
Actual: There is a preview for the theme from step 1

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It is covered by automated tests and just clears an image src on load, before adding it for themes.

String changes made/needed:

Comment 12

[Mark Striemer [:mstriemer]]

Comment on attachment 9036698 [details]
Bug 1519616 - Clear theme preview for themes that don't have previews r?aswan

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: See other patch, both are required.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky):

String changes made/needed:

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9036678 [details]
Bug 1519616 - Explicitly clear theme preview on details for non-themes r?aswan

[Triage Comment]
Fixes a kinda-funny regression with theme previews in about:addons. Verified on Nightly and new tests added. Approved for 65.0b12.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2ea881a24d05
https://hg.mozilla.org/releases/mozilla-beta/rev/86f5a024cd49

Comment 15

[Catalin Sasca, Desktop Test Engineering [:csasca]]

I successfully reproduced the issue on Firefox 66.0a1 (2019-01-12) under Windows 7 (x64) using the STR from Comment 0.

The issue is no longer reproducible on Firefox Beta 65.0b12 (20190116191407). Tests were performed under Windows 7 (x64), Ubuntu 18.04 (x64) and macOS 10.12.