Preview of Themes is visible on other items in Add-ons Manager (about:addons)
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox64 | --- | unaffected |
firefox65 | + | verified |
firefox66 | + | verified |
People
(Reporter: Virtual, Assigned: mstriemer)
Details
(Keywords: nightly-community, regression, reproducible)
Attachments
(3 files)
348.85 KB,
video/mp4
|
Details | |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
STR:
- Use some external Light Themes/Appearances/Personas not build in browser (like https://addons.mozilla.org/addon/virtualfox/ for example)
- Open Add-ons Manager (about:addons)
- Open Themes tab
- Open external Light Themes/Appearances/Personas
- Open other item
and see that preview of Light Themes/Appearances/Personas is visible on other items
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•5 years ago
|
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Assuming LWT, migration pending so wontfix.
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
This affects static themes as well, taking
Assignee | ||
Comment 3•5 years ago
|
||
Can reproduce on 65, but not 64.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/de208c99e477 Explicitly clear theme preview on details for non-themes r=aswan
Assignee | ||
Comment 6•5 years ago
|
||
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0aba112c5ad9 Clear theme preview for themes that don't have previews r=aswan
Comment 8•5 years ago
|
||
Please nominate this for Beta approval when you get a chance. The final Beta build is being created on Thursday.
Comment 9•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/de208c99e477
https://hg.mozilla.org/mozilla-central/rev/0aba112c5ad9
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•5 years ago
|
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•5 years ago
|
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 10•5 years ago
|
||
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 66.0a1 (2019-01-16), so I'm marking this bug as VERIFIED.
Thank you very much! \o/
Updated•5 years ago
|
Assignee | ||
Comment 11•5 years ago
|
||
Comment on attachment 9036678 [details]
Bug 1519616 - Explicitly clear theme preview on details for non-themes r?aswan
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Bug 1506987
User impact if declined: After viewing a theme detail page, its preview image will be shown on other detail pages.
Is this code covered by automated tests?: Yes
Has the fix been verified in Nightly?: No
Needs manual test from QE?: Yes
If yes, steps to reproduce: 1. View the detail page for a theme
2. View the detail page for a plugin or extension
Expected: There is no preview image
Actual: There is a preview for the theme from step 1
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): It is covered by automated tests and just clears an image src
on load, before adding it for themes.
String changes made/needed:
Assignee | ||
Comment 12•5 years ago
|
||
Comment on attachment 9036698 [details]
Bug 1519616 - Clear theme preview for themes that don't have previews r?aswan
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: None
User impact if declined: See other patch, both are required.
Is this code covered by automated tests?: Yes
Has the fix been verified in Nightly?: No
Needs manual test from QE?: Yes
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky):
String changes made/needed:
Comment 13•5 years ago
|
||
Comment on attachment 9036678 [details]
Bug 1519616 - Explicitly clear theme preview on details for non-themes r?aswan
[Triage Comment]
Fixes a kinda-funny regression with theme previews in about:addons. Verified on Nightly and new tests added. Approved for 65.0b12.
Updated•5 years ago
|
Comment 14•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/2ea881a24d05
https://hg.mozilla.org/releases/mozilla-beta/rev/86f5a024cd49
Comment 15•5 years ago
|
||
I successfully reproduced the issue on Firefox 66.0a1 (2019-01-12) under Windows 7 (x64) using the STR from Comment 0.
The issue is no longer reproducible on Firefox Beta 65.0b12 (20190116191407). Tests were performed under Windows 7 (x64), Ubuntu 18.04 (x64) and macOS 10.12.
Description
•