1519640 - Missing languages in Thunderbird's spelling preferences

Status: RESOLVED FIXED

Description

[:aceman]

Just opening preferences tab I see this in console:
JavaScript strict warning: chrome://messenger/content/preferences/compose.js, line 176: ReferenceError: reference to undefined property "label"

And indeed, on the Composition->Spelling tab the Language menulist only offers an "undefined" item.

The failing code is (last line):
var inlineSpellChecker = new InlineSpellChecker();
var sortedList = inlineSpellChecker.sortDictionaryList(dictList);

// Remove any languages from the list.
languageMenuList.removeAllItems();
  
// append the dictionaries to the menu list...
for (var i = 0; i < count; i++)
  languageMenuList.appendItem(sortedList[i].label, sortedList[i].id);

I do have 2 dictionaries installed, one of which is enabled.

Comment 1

[Jorg K (GMT+2)]

Certainly from this change with I noticed looking at merged changesets:
8d5e2931f526 Zibi Braniecki — Bug 1509583 - Move InlineSpellChecker to sync over locale codes rather than indexes. r=Felipe
https://hg.mozilla.org/mozilla-central/rev/8d5e2931f526

Comment 2

[Jorg K (GMT+2)]

Attachment: 1519640-sorted-dict.patch

If you want to add more dictionaries to test, you must get them from AMO which serves WebExtension dictionaries, the only ones that will work on trunk; do not get them from ATN which still serves the old type.

This patch covers all call sites where the result of sortDictionaryList() is precessed.

Comment 3

[:aceman]

Comment on attachment 9036141 [details] [diff] [review]
1519640-sorted-dict.patch

Review of attachment 9036141 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this displays at least English (United States) as the only available language.
The other dictionaries are not listed, maybe for the reason you mention.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1275fb1bcae3
Port bug 1509583: sorted dictionary list now uses localeCode/displayName instead of id/label. r=aceman