Port bug 1459556: Move richlistbox#handlersView off of XBL

RESOLVED FIXED in Thunderbird 66.0

Status

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 66.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 7 obsolete attachments)

Assignee

Description

4 months ago

Actually the application list is empty because of the richlistbox de-XBL. So we need to follow - and remove a XBL too.

Assignee

Comment 1

4 months ago

I followed bug 1459556 and made two patches. This should make it easier for you to review the changes.

This one is a port of https://hg.mozilla.org/mozilla-central/rev/6b309d5725fe

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9036148 - Flags: review?(jorgk)
Assignee

Comment 2

4 months ago

This is a port of https://hg.mozilla.org/mozilla-central/rev/4106f2f28462

The change in mail/components/preferences/applications.inc.xul is additional to show a border around the listheaders.

Attachment #9036149 - Flags: review?(jorgk)

Comment 3

4 months ago

Umm, can you attach part 2 as well ;-)

Assignee

Comment 4

4 months ago

I added part 1 two times to be sure you see it. ;-)

This time the correct patch.

Attachment #9036149 - Attachment is obsolete: true
Attachment #9036149 - Flags: review?(jorgk)
Attachment #9036150 - Flags: review?(jorgk)

Comment 5

4 months ago

One porting mistake: We use gApplicationsPane.

Comment 6

4 months ago

One porting mistake, you missed a hunk.

Attachment #9036148 - Attachment is obsolete: true
Attachment #9036150 - Attachment is obsolete: true
Attachment #9036148 - Flags: review?(jorgk)
Attachment #9036150 - Flags: review?(jorgk)
Assignee

Comment 7

4 months ago

Fixed the pane name.

Attachment #9036152 - Attachment is obsolete: true
Attachment #9036154 - Flags: review?(jorgk)

Comment 8

4 months ago

Comment on attachment 9036154 [details] [diff] [review]
1519650-handlers-view-part2.patch

I had already fixed it.

Attachment #9036154 - Attachment is obsolete: true
Attachment #9036154 - Flags: review?(jorgk)

Updated

4 months ago
Attachment #9036152 - Attachment is obsolete: false

Comment 9

4 months ago

I get:
JavaScript error: chrome://messenger/content/preferences/applications.js, line 1348: TypeError: menu is null

I also doesn't work. If you use "Use Other", select an application, and then click somewhere in the pane, it jump back to the original selection. In fact, you can't switch to another application at all, it always switches back.

Comment 10

4 months ago

OK, the menu retrieval needed to change like elsewhere in the patch:
let menu = typeItem.querySelector(".actionsMenu");

Attachment #9036152 - Attachment is obsolete: true
Attachment #9036156 - Flags: review+

Comment 11

4 months ago

Comment on attachment 9036153 [details] [diff] [review]
1519650-handlers-view-part1.patch

This works now with part 2. Lots of details to get right in this port.

Attachment #9036153 - Flags: review+

Comment 12

4 months ago

Oops, another spot where menu = ... needed fixing.

Attachment #9036156 - Attachment is obsolete: true
Attachment #9036158 - Flags: review+

Comment 13

4 months ago

Damn, there are two rebuildView()s in that file, one for the cloud file stuff, the other for the applications. Undo the change for the former.

Attachment #9036158 - Attachment is obsolete: true

Updated

4 months ago
Attachment #9036160 - Flags: review+

Comment 14

4 months ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/34939e75acc1
Port bug 1459556, part 1: Remove the implementation from the "handler" binding. r=jorgk
https://hg.mozilla.org/comm-central/rev/253562a57fb5
Port bug 1459556, part 2: Remove the "handler" binding. r=jorgk

Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED

Updated

4 months ago
Target Milestone: --- → Thunderbird 66.0
You need to log in before you can comment on or make changes to this bug.