1519650 - Port bug 1459556: Move richlistbox#handlersView off of XBL

Status: RESOLVED FIXED

(Thunderbird :: Preferences, task)

Description

[Richard Marti (:Paenglab)]

Actually the application list is empty because of the richlistbox de-XBL. So we need to follow - and remove a XBL too.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1519650-handlers-view-part1.patch

I followed bug 1459556 and made two patches. This should make it easier for you to review the changes.

This one is a port of https://hg.mozilla.org/mozilla-central/rev/6b309d5725fe

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1519650-handlers-view-part1.patch

This is a port of https://hg.mozilla.org/mozilla-central/rev/4106f2f28462

The change in mail/components/preferences/applications.inc.xul is additional to show a border around the listheaders.

Comment 3

[Jorg K (CEST = GMT+2)]

Umm, can you attach part 2 as well ;-)

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1519650-handlers-view-part2.patch

I added part 1 two times to be sure you see it. ;-)

This time the correct patch.

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1519650-handlers-view-part2.patch

One porting mistake: We use gApplicationsPane.

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: 1519650-handlers-view-part1.patch

One porting mistake, you missed a hunk.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1519650-handlers-view-part2.patch

Fixed the pane name.

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 9036154 [details] [diff] [review]
1519650-handlers-view-part2.patch

I had already fixed it.

Comment 9

[Jorg K (CEST = GMT+2)]

I get:
JavaScript error: chrome://messenger/content/preferences/applications.js, line 1348: TypeError: menu is null

I also doesn't work. If you use "Use Other", select an application, and then click somewhere in the pane, it jump back to the original selection. In fact, you can't switch to another application at all, it always switches back.

Comment 10

[Jorg K (CEST = GMT+2)]

Attachment: 1519650-handlers-view-part2.patch

OK, the menu retrieval needed to change like elsewhere in the patch:
let menu = typeItem.querySelector(".actionsMenu");

Comment 11

[Jorg K (CEST = GMT+2)]

Comment on attachment 9036153 [details] [diff] [review]
1519650-handlers-view-part1.patch

This works now with part 2. Lots of details to get right in this port.

Comment 12

[Jorg K (CEST = GMT+2)]

Attachment: 1519650-handlers-view-part2.patch

Oops, another spot where menu = ... needed fixing.

Comment 13

[Jorg K (CEST = GMT+2)]

Attachment: 1519650-handlers-view-part2.patch

Damn, there are two rebuildView()s in that file, one for the cloud file stuff, the other for the applications. Undo the change for the former.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/34939e75acc1
Port bug 1459556, part 1: Remove the implementation from the "handler" binding. r=jorgk
https://hg.mozilla.org/comm-central/rev/253562a57fb5
Port bug 1459556, part 2: Remove the "handler" binding. r=jorgk