Closed Bug 1519673 Opened 7 years ago Closed 7 years ago

`arc patch --nobranch` still causes working copy churn

Categories

(Conduit :: Phabricator, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: botond, Unassigned)

Details

My understanding is that when you run arc patch --nobranch DXXXXX, it's supposed to apply the patch on top of the currently checked out revision.

One of the reasons I might call this, over arc patch DXXXXX, is to avoid working copy churn, and a consequent long rebuild. However, it seems I'm not successful:

$ arc patch --nobranch D16384
Updating to the revision's base commit
1336 files updated, 0 files merged, 41 files removed, 0 files unresolved
Created and checked out bookmark arcpatch-D16384.
 OKAY  Successfully committed patch.

Even though the end state is what I intended (the patch is applied on top of what I had checked out before running the command), I've caused 1336 files to be touched.

This seems unfortunate. Can this be avoided?

yes, this is unfortunate.

we're moving away from depending on arc, and are currently implementing a 'patch' command to moz-phab (bug 1503903).

we'll try to make sure this doesn't happen there.

Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.