Make the AB card pane also themeable

RESOLVED FIXED in Thunderbird 66.0

Status

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 66.0

Thunderbird Tracking Flags

(thunderbird65 fixed, thunderbird66 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago

With the dark theme, the card pane in the AB is still white. We should make it dark too.

Assignee

Comment 1

4 months ago

This makes the background dark and the text light.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9036192 - Flags: review?(jorgk)

Comment 2

4 months ago

I though we rejected that idea before: Bug 1504187 comment #2.

Assignee

Comment 3

4 months ago

I think we should do this. It's not a message content that changes depending of the sender settings. It's always the same content type in it and makes the dark theme more consistent.

Comment 4

4 months ago
Comment on attachment 9036192 [details] [diff] [review]
1519696-AB-cardPane-themeable.patch

Review of attachment 9036192 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/addrbook/content/addressbook.xul
@@ -667,5 @@
>  
>    <!-- The main address book three pane -->
>    <hbox id="abContent" flex="1">
>      <vbox id="dirTreeBox" persist="width collapsed">
> -      <sidebarheader id="abDirTreeHeader" hidden="true" align="center">

Why are we removing this? Is it not needed? It's hidden, and I don't see any code that unhides it. So why was it there in the first place?
Assignee

Comment 5

4 months ago

Ah yes, this one. Forgot to mention. It was hidden in bug 667245 8 years ago. The header makes no sense, see bug 667245 comment 17. Since then it was hidden and now I remove it.

Comment 6

4 months ago

Comment on attachment 9036192 [details] [diff] [review]
1519696-AB-cardPane-themeable.patch

More gloom. Well, the dark grey is quite OK.

Attachment #9036192 - Flags: review?(jorgk) → review+
Assignee

Updated

4 months ago
Keywords: checkin-needed

Comment 7

4 months ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ef82c0a03335
Make the AB card pane themeable. r=jorgk

Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

4 months ago
Target Milestone: --- → Thunderbird 66.0

Comment 8

4 months ago

Comment on attachment 9036192 [details] [diff] [review]
1519696-AB-cardPane-themeable.patch

That could be OK to have for TB 65 beta 3.

Attachment #9036192 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.