1519747 - Split culling pass from primitive preparation in webrender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Glenn Watson [:gw]]

It turns out that the primitive dependency calculation for picture caching ends up having to do almost the same work as the visibility and clip chain generation code.

However, we don't want to run all the primitive preparation code up front, since we can skip that for valid tiles.

We should split the current prepare pass into a visibility pass and a preparation pass. This will allow picture caching to be much faster in CPU time (by reducing work). It also opens up the possibility of dirty regions instead of a single dirty rect. Finally, it unblocks the work needed to fix an invalidation bug that occurs when scrolling + a new display list arrives.

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1519747 - Split primitive preparation into a separate culling pass.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7f7558083b2
Split primitive preparation into a separate culling pass. r=kvark

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b7f7558083b2