Split culling pass from primitive preparation in webrender

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: gw, Assigned: gw)

Tracking

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago

It turns out that the primitive dependency calculation for picture caching ends up having to do almost the same work as the visibility and clip chain generation code.

However, we don't want to run all the primitive preparation code up front, since we can skip that for valid tiles.

We should split the current prepare pass into a visibility pass and a preparation pass. This will allow picture caching to be much faster in CPU time (by reducing work). It also opens up the possibility of dirty regions instead of a single dirty rect. Finally, it unblocks the work needed to fix an invalidation bug that occurs when scrolling + a new display list arrives.

Assignee

Updated

4 months ago
Assignee: nobody → gwatson

Comment 2

4 months ago
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b7f7558083b2
Split primitive preparation into a separate culling pass. r=kvark

Comment 3

4 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.