Closed Bug 1519755 Opened 6 years ago Closed 6 years ago

More errors with Lightning startup

Categories

(Calendar :: Lightning Only, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file)

I'm still seeing Lightning fail to start properly sometimes on my main profile (running 65.0b2).

I'm not sure if there's been some changes to how XBL works, but bindings keep being used before their constructors have run.

Fixes two more issues of things being called out-of-order. I've made the startup functions async all the way up to the onload handler.

Attachment #9036252 - Flags: review?(philipp)
Comment on attachment 9036252 [details] [diff] [review] 1519755-calendar-bindings-1.diff Review of attachment 9036252 [details] [diff] [review]: ----------------------------------------------------------------- async all the way, I like that! We'll see if there are other race conditions down the line.
Attachment #9036252 - Flags: review?(philipp) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/582cf461149a
Fix more XBL binding errors at Lightning startup. r=philipp

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.8
Comment on attachment 9036252 [details] [diff] [review] 1519755-calendar-bindings-1.diff Let's get this in the next 65 beta. I didn't realise at the time there was going to be one.
Attachment #9036252 - Flags: approval-calendar-beta?(philipp)

Sorry, approval hasn't arrived on time :-(

Attachment #9036252 - Flags: approval-calendar-beta?(philipp) → approval-calendar-beta+
Comment on attachment 9036252 [details] [diff] [review] 1519755-calendar-bindings-1.diff Not doing another TB 65 beta and the change is already in TB 66 (beta)/ Cal 6.8.
Attachment #9036252 - Flags: approval-calendar-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: