1519755 - More errors with Lightning startup

Status: RESOLVED FIXED

Description

[Geoff Lankow (:darktrojan)]

I'm still seeing Lightning fail to start properly sometimes on my main profile (running 65.0b2).

I'm not sure if there's been some changes to how XBL works, but bindings keep being used before their constructors have run.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1519755-calendar-bindings-1.diff

Fixes two more issues of things being called out-of-order. I've made the startup functions async all the way up to the onload handler.

Comment 2

[Philipp Kewisch [:Fallen] [:📆]]

Comment on attachment 9036252 [details] [diff] [review]
1519755-calendar-bindings-1.diff

Review of attachment 9036252 [details] [diff] [review]:
-----------------------------------------------------------------

async all the way, I like that! We'll see if there are other race conditions down the line.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/582cf461149a
Fix more XBL binding errors at Lightning startup. r=philipp

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9036252 [details] [diff] [review]
1519755-calendar-bindings-1.diff

Let's get this in the next 65 beta. I didn't realise at the time there was going to be one.

Comment 5

[Jorg K (GMT+2)]

Sorry, approval hasn't arrived on time :-(

Comment 6

[Jorg K (GMT+2)]

Comment on attachment 9036252 [details] [diff] [review]
1519755-calendar-bindings-1.diff

Not doing another TB 65 beta and the change is already in TB 66 (beta)/ Cal 6.8.