More errors with Lightning startup

RESOLVED FIXED in 6.8

Status

enhancement
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: darktrojan, Assigned: darktrojan)

Tracking

unspecified

Details

Attachments

(1 attachment)

(Assignee)

Description

3 months ago

I'm still seeing Lightning fail to start properly sometimes on my main profile (running 65.0b2).

I'm not sure if there's been some changes to how XBL works, but bindings keep being used before their constructors have run.

(Assignee)

Comment 1

3 months ago

Fixes two more issues of things being called out-of-order. I've made the startup functions async all the way up to the onload handler.

Attachment #9036252 - Flags: review?(philipp)
Comment on attachment 9036252 [details] [diff] [review]
1519755-calendar-bindings-1.diff

Review of attachment 9036252 [details] [diff] [review]:
-----------------------------------------------------------------

async all the way, I like that! We'll see if there are other race conditions down the line.
Attachment #9036252 - Flags: review?(philipp) → review+
(Assignee)

Updated

3 months ago
Keywords: checkin-needed

Comment 3

3 months ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/582cf461149a
Fix more XBL binding errors at Lightning startup. r=philipp

Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.8
(Assignee)

Comment 4

3 months ago
Comment on attachment 9036252 [details] [diff] [review]
1519755-calendar-bindings-1.diff

Let's get this in the next 65 beta. I didn't realise at the time there was going to be one.
Attachment #9036252 - Flags: approval-calendar-beta?(philipp)

Comment 5

3 months ago

Sorry, approval hasn't arrived on time :-(

Attachment #9036252 - Flags: approval-calendar-beta?(philipp) → approval-calendar-beta+

Comment 6

3 months ago
Comment on attachment 9036252 [details] [diff] [review]
1519755-calendar-bindings-1.diff

Not doing another TB 65 beta and the change is already in TB 66 (beta)/ Cal 6.8.
Attachment #9036252 - Flags: approval-calendar-beta+
You need to log in before you can comment on or make changes to this bug.