Prebinding doesn't play well with mach-o xptcinvoke/xptcstubs implementation

VERIFIED FIXED

Status

()

VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: bryner, Assigned: bryner)

Tracking

Trunk
PowerPC
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

17 years ago
If you build with prebinding enabled, and the prebinding is out of date, the app
fails to start.  This appears to be because some functions that are implemented
in assembly reside in the data section intead of the text section.  Making them
reside in the text section involves using an indirect call stub.  I also had to
change the manner in which the method index is passed from StubNNN to
SharedStub, since r12 will be clobbered by the indirect call.
(Assignee)

Comment 1

17 years ago
Created attachment 87774 [details] [diff] [review]
patch

beard, pavlov, can you guys r/sr?
(Assignee)

Updated

17 years ago
Blocks: 152130
(Assignee)

Comment 2

17 years ago
Created attachment 88559 [details] [diff] [review]
patch v2

Ok, this one is actually quite a bit less scary.  I'm using m4 to generate the
stub functions in the .s file.
Attachment #87774 - Attachment is obsolete: true

Comment 3

17 years ago
Comment on attachment 88559 [details] [diff] [review]
patch v2

r=pavlov

looks ok to me
Attachment #88559 - Flags: review+

Comment 4

17 years ago
Comment on attachment 88559 [details] [diff] [review]
patch v2

sr=beard, looks very cool
Attachment #88559 - Flags: superreview+
(Assignee)

Comment 5

17 years ago
Checked into the trunk and CHIMERA_M1_0_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 6

17 years ago
Patch checkin verified on trunk and CHIMERA_M1_0_BRANCH -
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.