1519792 - Move pc field from BaselineCodeGen to BaselineCompilerHandler

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Jan de Mooij [:jandem]]

Goal here is to move the pc field from BaselineCodeGen to BaselineCompilerHandler, so the interpreter generator no longer depends on it.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1519792 part 1 - Move some BaselineCompiler methods to the end of the file. r?djvj!

The next patch will template-specialize some of the emit_JSOP_FOO methods, but
the C++ compiler wants that to happen before we call these methods in emitBody.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1519792 part 2 - Move pc field from BaselineCodeGen to BaselineCompilerHandler. r?djvj!

JSOPs like JSOP_INT8 that depend on the pc need to be specialized now for the
interpreter. I added MOZ_CRASH versions of these that we can implement later.

This split is a bit pessimistic: we should actually (partially) share codegen
for some of these ops like JSOP_RESUME. However it's easier to revisit this
later when we need to implement these ops for the interpreter.

Depends on D16441

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e52ffae5eb4
part 1 - Move some BaselineCompiler methods to the end of the file. r=djvj
https://hg.mozilla.org/integration/autoland/rev/cbe224190304
part 2 - Move pc field from BaselineCodeGen to BaselineCompilerHandler. r=djvj

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1e52ffae5eb4
https://hg.mozilla.org/mozilla-central/rev/cbe224190304