Closed Bug 1519792 Opened 11 months ago Closed 11 months ago

Move pc field from BaselineCodeGen to BaselineCompilerHandler

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(2 files)

Goal here is to move the pc field from BaselineCodeGen to BaselineCompilerHandler, so the interpreter generator no longer depends on it.

The next patch will template-specialize some of the emit_JSOP_FOO methods, but
the C++ compiler wants that to happen before we call these methods in emitBody.
JSOPs like JSOP_INT8 that depend on the pc need to be specialized now for the
interpreter. I added MOZ_CRASH versions of these that we can implement later.

This split is a bit pessimistic: we should actually (partially) share codegen
for some of these ops like JSOP_RESUME. However it's easier to revisit this
later when we need to implement these ops for the interpreter.

Depends on D16441
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e52ffae5eb4
part 1 - Move some BaselineCompiler methods to the end of the file. r=djvj
https://hg.mozilla.org/integration/autoland/rev/cbe224190304
part 2 - Move pc field from BaselineCodeGen to BaselineCompilerHandler. r=djvj
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.