Port Bug 1490765 "replace configure.in with moz.configure stuff" to SeaMonkey

RESOLVED FIXED in SeaMonkey2.63

Status

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: frg, Assigned: frg)

Tracking

Trunk
SeaMonkey2.63

SeaMonkey Tracking Flags

(seamonkey2.53 unaffected, seamonkey2.57esr unaffected, seamonkey2.63 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

4 months ago

Follow-up bug from Bug 1490867 for SeaMonkey only. The temporary hack no longer works.

+++ This bug was initially created as a clone of Bug #1490867 +++

After Bug 1490765 the configure.in in mail and suite will no longer get called but according to glandium (https://bugzilla.mozilla.org/show_bug.cgi?id=1490765#c4) it can be replaced by moz.configure stuff

Assignee

Comment 1

4 months ago

Patch from Bill. r+ from me.

This removes SeaMonkey's reliance on being a subconfigure. This was necessary after the completion of Bug 1490765.

The moztopsrcdir, commtopsrcdir and related variables are retained.
Per Fallen this saves a lot of editing, and makes the patch far less intrusive.

  • Move remaining suite/configure.in pieces to moz.configure
  • Move moz* and comm* variables from confvars.sh to moz.configure
  • Remove configure.in

MOZ_RUST_URLPARSE can go because it was removed in Bug 1415206.

Attachment #9036343 - Flags: review+
Assignee

Comment 2

4 months ago
Posted patch 1519872-seamonkey-part.patch (obsolete) — Splinter Review

esr60 2.57 only. Minor cleanup.

Attachment #9036349 - Flags: review?(iann_bugzilla)
Attachment #9036349 - Flags: approval-comm-esr60?
Assignee

Comment 3

4 months ago

and now the correct file...

Attachment #9036349 - Attachment is obsolete: true
Attachment #9036349 - Flags: review?(iann_bugzilla)
Attachment #9036349 - Flags: approval-comm-esr60?
Attachment #9036354 - Flags: review?(iann_bugzilla)
Attachment #9036354 - Flags: approval-comm-esr60?

Comment 4

4 months ago

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/ec1e8d938552
Replace configure.in with moz.configure in SeaMMonkey. r=frg

Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Assignee

Comment 5

4 months ago

Resolved with a ttypo in the comment. Too fast. doh.

Target Milestone: --- → SeaMonkey2.63

Comment 6

4 months ago

Comment on attachment 9036354 [details] [diff] [review]
1519872-seamonkey-esr60.patch

r/a=me

Attachment #9036354 - Flags: review?(iann_bugzilla)
Attachment #9036354 - Flags: review+
Attachment #9036354 - Flags: approval-comm-esr60?
Attachment #9036354 - Flags: approval-comm-esr60+
You need to log in before you can comment on or make changes to this bug.