Closed Bug 1519878 Opened 2 years ago Closed 2 years ago

implement full width ds-list items

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 66
Iteration:
66.4 - Jan 21 - 27
Tracking Status
firefox66 --- fixed

People

(Reporter: dmose, Assigned: Mardak)

References

Details

(Keywords: github-merged)

User Story

QA steps: use dev-test-all and check that all "Full width" sections (towards the bottom in the 2/3-wide left side) have images and have one item per row as well as show borders and/or numbers as appropriately titled

Attachments

(2 files)

These double-wide items will also have double-wide images.

Summary: implement double-wide ds-list items → [stretch] implement double-wide ds-list items
Iteration: --- → 66.4 - Jan 21 - 27
Priority: -- → P1

Potentially any list can be full width instead of split into 1/3 columns.
This is specified with a property full_width: true
These include the excerpt (unlike other Lists)
Design says these will only be used with an image (but that's just a separate has_images property)
The images are 2x as wide so 144px.

Assignee: nobody → edilee
Summary: [stretch] implement double-wide ds-list items → [stretch] implement full width ds-list items
Blocks: 1522752
Keywords: github-merged
Summary: [stretch] implement full width ds-list items → implement full width ds-list items
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

Hi,

Can you please update QA steps.

Flags: needinfo?(edilee)
User Story: (updated)
Flags: needinfo?(edilee)
User Story: (updated)

QA Results:

Tested on :

FF Nightly version : 67.0a1 (2019-01-31)
OS : Mac and Windows 10 Pro

Results attached QA Results : bug - 1519878.png

All "Full width" sections (towards the bottom in the 2/3-wide left side) have images and have one item per row as well as show borders and/or numbers as appropriately titled.

Closing as verified.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.