Closed Bug 1519879 Opened 2 years ago Closed 2 years ago

ensure spoc items work in ds lists

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 67
Iteration:
67.1 - Jan 28 - Feb 10
Tracking Status
firefox66 + verified
firefox67 --- verified

People

(Reporter: dmose, Assigned: pdahiya)

References

Details

(Keywords: github-merged)

Attachments

(3 files)

This may just be QA verification, or it may also involve a bit of code. It should also work on double-wide list items, if those are implemented by the time this is done.

I dunno if this is needed for MVP, but I do think it's something on Nick's mind.

Iteration: --- → 66.3 - Jan 7 - 20
Priority: -- → P2

This might be easier now than I initially predicted, it might just work if the server were to pass spoc probability and position info into the component via the layout. Super low hanging fruit here, with pretty high gains.

Iteration: 66.3 - Jan 7 - 20 → 66.4 - Jan 21 - 27
Priority: P2 → P1
Iteration: 66.4 - Jan 21 - 27 → 67.1 - Jan 28 - Feb 10
Assignee: nobody → pdahiya

Nick, is there a clear decision on SPOCs in the MVP for 66 for lists?

Flags: needinfo?(nchapman)

[Tracking Requested - why for this release]:

Blocks: 1526066
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Depends on: 1526861
Depends on: 1527195
Flags: needinfo?(nchapman)

How to test:

  1. go to about:config
  2. search for discoverystream.config and set preference to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://gist.githubusercontent.com/punamdahiya/4852948f6b24e1a82f4cc2f107ddc234/raw/7e54aa261eeeb718b94a55965b1da28348df93dc/feed.json"}
  3. Open new tab and search for 'sponsored' text in list items and verify spoc items show up in list.

NI Brahmini to help QA the fix. Thanks!

Flags: needinfo?(bnagabandi)

QA Results : Pass

Tested on :

FF Nightly version : 67.0a1 (2019-02-14)
OS : Mac and Windows 10 Pro

Observations :

  • With the pref, I'm seeing 3 spoc items.

Results attached : QA Results : bug - 1519879.png

Closing as verified.

Flags: needinfo?(bnagabandi)
Status: RESOLVED → VERIFIED
Depends on: 1527437

Can you fill out the uplift request form for this?

Flags: needinfo?(pdahiya)

Comment on attachment 9043732 [details]
Bug 1519879 - Spoc Items in List

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1512725

User impact if declined

Required to display sponsored content in List layout for Pocket New Tab experiments

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

Yes

If yes, steps to reproduce

  1. go to about:config
  2. Search for discoverystream.config and set preference to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://gist.githubusercontent.com/punamdahiya/4852948f6b24e1a82f4cc2f107ddc234/raw/7e54aa261eeeb718b94a55965b1da28348df93dc/feed.json"}
  3. Open new tab and search for 'sponsored' text in list items and verify spoc items show up in list.

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

UI changes touching List component for pocket new tab experiment that's not turned on by default in beta

String changes made/needed

None

Flags: needinfo?(pdahiya)
Attachment #9043732 - Flags: approval-mozilla-beta?

Comment on attachment 9043732 [details]
Bug 1519879 - Spoc Items in List

Planned work for pocket/new tab.
OK for beta uplift, should land for beta 9.
Landing order: bug 1519879, bug 1525494, bug 1526861, bug 1524669, bug 1527195, bug 1525391, bug 1527347, bug 1525366, bug 1527626, bug 1527397, bug 1518258, bug 1527701, bug 1527370.

Attachment #9043732 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

(In reply to Brahmini Nagabandi from comment #11)

Created attachment 9044061 [details]
QA Results : bug - 1519879.png

QA Results : Pass

Tested on :

FF Nightly version : 67.0a1 (2019-02-14)
OS : Mac and Windows 10 Pro

Observations :

  • With the pref, I'm seeing 3 spoc items.

Results attached : QA Results : bug - 1519879.png

Closing as verified.

Can you please verify this issue on Firefox 66 Beta 9 (https://archive.mozilla.org/pub/firefox/candidates/66.0b9-candidates/build1/)?

Flags: qe-verify+
Flags: needinfo?(bnagabandi)

Not sure if this was accidentally marked verified. There was no accompanying verification comment.

BETA Testing:

QA Results : Pass

*Tested on *

FF Beta version : 66.0b9 (64-bit)
OS : Mac and Windows 10 Pro

Date : Feb 21

Observations :

  • Using pref discoverystream.config set to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://gist.githubusercontent.com/punamdahiya/4852948f6b24e1a82f4cc2f107ddc234/raw/7e54aa261eeeb718b94a55965b1da28348df93dc/feed.json"}

I'm seeing 3 spoc items. Works as expected.

Verified.

Flags: needinfo?(bnagabandi)

(In reply to Brahmini Nagabandi from comment #18)

BETA Testing:

QA Results : Pass

*Tested on *

FF Beta version : 66.0b9 (64-bit)
OS : Mac and Windows 10 Pro

Date : Feb 21

Observations :

  • Using pref discoverystream.config set to
    {"enabled":true,"show_spocs":true,"layout_endpoint":"https://gist. githubusercontent.com/punamdahiya/4852948f6b24e1a82f4cc2f107ddc234/raw/ 7e54aa261eeeb718b94a55965b1da28348df93dc/feed.json"}

I'm seeing 3 spoc items. Works as expected.

Verified.

Thanks for verifying this!

Flags: qe-verify+
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.