Closed Bug 1519884 Opened 10 months ago Closed 7 months ago

Improve help text for --test argument

Categories

(Testing :: Raptor, enhancement, P3)

Version 3
enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: rwood, Assigned: ivankhyung)

Details

(Keywords: good-first-bug, Whiteboard: [lang=py])

Attachments

(2 files, 1 obsolete file)

As :ehsan noted, the Raptor help doesn't make it clear that the --test argument can be either a top-level test suite (i.e. --test raptor-tp6-1) or a subtest of a page within a tp6* suite (i.e. --test raptor-tp6-amazon-firefox). The Raptor help text [1] should be updated to reflect that.

[1] https://searchfox.org/mozilla-central/rev/c43240cef5829b8a2dec118faff8a5e1fec6ae1b/testing/raptor/raptor/cmdline.py#17

Assignee: nobody → wyattkyte
Status: NEW → ASSIGNED
Assignee: wyattkyte → nobody
Status: ASSIGNED → NEW
Whiteboard: [lang=py]

Hello!

Can I work on this bug?

What would be a good replacement message?

(In reply to Ivan Yung from comment #1)

Hello!

Can I work on this bug?

What would be a good replacement message?

Hi Ivan,

Sorry for my slow response, I was out of the office last week. Thank you for your interest in contributing a patch for Raptor - I am assigning the bug to you.

As for a replacement help message, I'd suggest something like:

"name of raptor test to run (can be a top-level suite name i.e. '--test raptor-speedometer','--test raptor-tp6-1', or for page-load tests a suite sub-test i.e. '--test raptor-tp6-google-firefox')"

Assignee: nobody → ivankhyung
Status: NEW → ASSIGNED

(In reply to Ivan Yung from comment #3)

Thanks Ivan. Do you have permissions to push to try (Moz commit access L1)? If not, I'll push to try on your behalf once you update your patch with the lint error fix.

Flags: needinfo?(ivankhyung)

I don't think I have permission to push. This is my second bug so I'm still new to a lot of this.

Flags: needinfo?(ivankhyung)

Depends on D27608

(In reply to Ivan Yung from comment #5)

I don't think I have permission to push. This is my second bug so I'm still new to a lot of this.

No worries I'll push your patch to try, thanks for the update (btw, in future please do 'commit --amend' for little patch updates like this, so that there is only one single commit in the patch. Np this time though it's fine).

Pushed by rwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/20bbaead9017
Improve help text for --test argument r=rwood

(In reply to Pulsebot from comment #9)

I believe that was the first Raptor contributor patch landed - thanks Ivan!

Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5506b872b4e5
Backed out changeset 20bbaead9017 for causing mozlint failure in /builds/worker/checkouts/gecko/testing/raptor/raptor/cmdline.py CLOSED TREE

Is there any work I should do to resolve this?

Flags: needinfo?(rwood)

(In reply to Ivan Yung from comment #12)

Is there any work I should do to resolve this?

Ah, I missed this. The patch was backed out because of 'trailing whitespace' on one line:

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=20bbaead9017b5626e13b5e438dfc27030158ccc&selectedJob=240983307

I pushed it to try in comment 9 and it was green, so not sure what happened there.

Anyway please abandon the two patches in this bug and create a new one (without the trailing whitespace) and with just the one single commit in phab, and I'll push that to try and land it, thanks!

Flags: needinfo?(rwood)
Flags: needinfo?(ivankhyung)

I've made the new commit. Hope it works this time!

Flags: needinfo?(ivankhyung) → needinfo?(rwood)
Attachment #9058807 - Attachment is obsolete: true

Thanks for the update! Ah yes I didn't even see your 2nd original patch above that fixed the lint error (I only landed your first patch without that so that's why it was backed out). Anyway here's a try push with your latest patch from comment 14 just to make sure there's no lint errors:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c19292e96a1ec52f9f8828346625f1af37458e9

Flags: needinfo?(rwood)
Pushed by rwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a65215aac07
Improve help text for --test argument r=rwood
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.