1519902 - Port Bug 1202085 "Part 2: Add an optional document argument to imgICache::FindEntryProperties()" to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

In order to get the right entry in imgICache::FindEntryProperties() the current document should be provided.

See Bug 1202085 part 4:
Part 4: Add an ID for controlled document to the image cache key

This ID will be null for non-controlled documents and also for image cache
entries for which a document is not available, and it will be the numerical
value of the document pointer for controlled documents.

This effectively makes sure that a controlled document doesn't share its
image cache entries with anything else.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1519902-imagecache.patch

Simple fix. Not 100% sure what the implications currently are with it not done but probably only performance related.

Comment 2

[Ian Neal]

Comment on attachment 9036367 [details] [diff] [review]
1519902-imagecache.patch

r/a=me it was interesting reading the comment https://bugzilla.mozilla.org/show_bug.cgi?id=1202085#c44 about
https://hg.mozilla.org/mozilla-central/rev/9c5e6d68cc46 may be worth keeping in mind.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/54b1c3f11dee
Use current document for imageCache.findEntryProperties(). r=IanN

Comment 4

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/3687e78118a24c5c28c0cc4456c5b30ca0629d35

Target 2.49.5 after build 1
https://hg.mozilla.org/releases/comm-esr52/rev/659c9551e19da6a7a719e656ea8d899f53152ea7

may be worth keeping in mind.
I read the comment. I suspect this would need a revised function not a backout. Not sure.