Closed Bug 1519922 Opened 10 months ago Closed 10 months ago

Scrolling events are not proxied in IPC on desktop

Categories

(Core :: Disability Access APIs, defect)

All
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox64 --- wontfix
firefox65 --- fixed
firefox66 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

Attachments

(1 file)

I made a custom a11y::ProxyScrollingEvent for Android, but forgot to support proxying EVENT_SCROLLING_END in other platforms as well.

Hardware: All → Desktop
OS: All → Windows
Hardware: Desktop → All
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a01a559aa611
Call ProxyEvent for scrolling events on non-Android. r=Jamie
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

This is hurting low vision users using the ZoomText magnification software. It was reported to us by the ZoomText vendor. I'm going to have the vendor verify that this fixes the issue for them.

Eitan, thanks for fixing this so quickly! We should try and see if we can still get this uplifted to 65, so it's only 63 and 64 that are broken for ZoomText users.

Flags: needinfo?(eitan)
Assignee: nobody → eitan

The vendor reported that this fixes the issue for ZoomText.

Comment on attachment 9036386 [details]
Bug 1519922 - Call ProxyEvent for scrolling events on non-Android. r?Jamie!

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1519922

User impact if declined: ZoomText fails to detect scrolls

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is a straightforward fix to a very simple omission.

String changes made/needed:

Flags: needinfo?(eitan)
Attachment #9036386 - Flags: approval-mozilla-beta?

(In reply to Eitan Isaacson [:eeejay] from comment #7)

Feature/Bug causing the regression: Bug 1519922

Should be bug 1479591.

Comment on attachment 9036386 [details]
Bug 1519922 - Call ProxyEvent for scrolling events on non-Android. r?Jamie!

[Triage Comment]
Simple fix for a regression breaking the ZoomText a11y app. Approved for 65.0b12.

Attachment #9036386 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.