Remove boxobject usage in accessibility

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P3
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: enndeakin, Assigned: enndeakin)

Tracking

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

5 months ago
No description provided.
Assignee

Updated

5 months ago
Priority: -- → P3
Assignee

Updated

4 months ago
Attachment #9036407 - Flags: review?(jteh)

Comment 1

4 months ago
Comment on attachment 9036407 [details] [diff] [review]
Replace boxobjecct calls

Review of attachment 9036407 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/xul/XULTreeGridAccessible.cpp
@@ +413,5 @@
> +    return nsIntRect();
> +  }
> +
> +  nsIFrame* bodyFrame = bodyElement->GetPrimaryFrame();
> +  if (bodyFrame) {

Can you explain why we don't return nsIntRect(); if (!bodyFrame) like we do in XULTreeItemAccessibleBase::BoundsInCSSPixels? I guess you could argue potentially unusable coords are better than no coords, but I'm confused by the difference here.
Assignee

Comment 2

4 months ago

I probably wrote those two bits at different times. I think it should just return nsIntRect() in both cases as the tree is hidden when it has no frame. I will make that change.

Comment 3

4 months ago
Comment on attachment 9036407 [details] [diff] [review]
Replace boxobjecct calls

(In reply to Neil Deakin from comment #2)

> I probably wrote those two bits at different times. I think it should just return nsIntRect() in both cases as the tree is hidden when it has no frame. I will make that change.

Agreed. r+ with that change made.
Attachment #9036407 - Flags: review?(jteh) → review+

Comment 4

4 months ago
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1178c5fddda7
Don't use boxobject properties in accessibility, r=jteh

Comment 5

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.