1519955 - Remove boxobject usage in accessibility

Status: RESOLVED FIXED

(Core :: XUL, enhancement, P3)

Description

[Neil Deakin]

Attachment: Replace boxobjecct calls

Comment 1

[James Teh [:Jamie]]

Comment on attachment 9036407 [details] [diff] [review]
Replace boxobjecct calls

Review of attachment 9036407 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/xul/XULTreeGridAccessible.cpp
@@ +413,5 @@
> +    return nsIntRect();
> +  }
> +
> +  nsIFrame* bodyFrame = bodyElement->GetPrimaryFrame();
> +  if (bodyFrame) {

Can you explain why we don't return nsIntRect(); if (!bodyFrame) like we do in XULTreeItemAccessibleBase::BoundsInCSSPixels? I guess you could argue potentially unusable coords are better than no coords, but I'm confused by the difference here.

Comment 2

[Neil Deakin]

I probably wrote those two bits at different times. I think it should just return nsIntRect() in both cases as the tree is hidden when it has no frame. I will make that change.

Comment 3

[James Teh [:Jamie]]

Comment on attachment 9036407 [details] [diff] [review]
Replace boxobjecct calls

(In reply to Neil Deakin from comment #2)

> I probably wrote those two bits at different times. I think it should just return nsIntRect() in both cases as the tree is hidden when it has no frame. I will make that change.

Agreed. r+ with that change made.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1178c5fddda7
Don't use boxobject properties in accessibility, r=jteh

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1178c5fddda7