1519972 - The folderpane-mode-selector-menulist is almost not readable with dark Linux theme

Status: RESOLVED FIXED

Description

[Richard Marti (:Paenglab)]

Attachment: screenshot.png

With a dark Linux theme and default TB theme the folderpane-mode-selector-menulist is hard to read with the white text on the light background, see screenshot.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1519972-folderPane-toolbar-brighttext.patch

This fixes it by adding a toolbox (folderPane-toolbox) to make the toolbarIconColor.js script apply the "brighttext" attribute. With this the folderpane-mode-selector-menulist gets the correct colours like when the dark TB theme is enabled.

Comment 2

[:aceman]

Please add screenshot with the patch.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: with-patch.png

Comment 4

[:aceman]

Thanks. There is some gap now after the single element of Folder mode selector.

Comment 5

[Richard Marti (:Paenglab)]

This is a space I inserted to check the toolbar background color.

Comment 6

[:aceman]

Comment on attachment 9036423 [details] [diff] [review]
1519972-folderPane-toolbar-brighttext.patch

Review of attachment 9036423 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/messenger.xul
@@ +454,5 @@
>                <sidebarheader id="folderPaneHeader" hidden="true" align="center"/>
> +              <toolbox id="folderPane-toolbox">
> +                <toolbar id="folderPane-toolbar"
> +                         class="inline-toolbar"
> +                         toolboxid="mail-toolbox"

Should the toolboxid match the id of the parent toolbox in this case? I'm not sure what effect it has: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Property/toolboxid

Comment 7

[Richard Marti (:Paenglab)]

When I change it to toolboxid="folderPane-toolbox" the folderpane-mode-selector-menulist is no more shown and I can't place buttons etc. on this toolbar.

Comment 8

[:aceman]

Comment on attachment 9036423 [details] [diff] [review]
1519972-folderPane-toolbar-brighttext.patch

Review of attachment 9036423 [details] [diff] [review]:
-----------------------------------------------------------------

OK, maybe because that element is part of the palette in mail-toolbox.

Comment 9

[Richard Marti (:Paenglab)]

Thanks

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/10e4790e1368
Apply the [brighttext] attribute to the folderPane-toolbar too. r=aceman