The folderpane-mode-selector-menulist is almost not readable with dark Linux theme

RESOLVED FIXED in Thunderbird 66.0

Status

defect
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 66.0
All
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Posted image screenshot.png

With a dark Linux theme and default TB theme the folderpane-mode-selector-menulist is hard to read with the white text on the light background, see screenshot.

This fixes it by adding a toolbox (folderPane-toolbox) to make the toolbarIconColor.js script apply the "brighttext" attribute. With this the folderpane-mode-selector-menulist gets the correct colours like when the dark TB theme is enabled.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9036423 - Flags: review?(acelists)

Please add screenshot with the patch.

Posted image with-patch.png

Thanks. There is some gap now after the single element of Folder mode selector.

This is a space I inserted to check the toolbar background color.

Comment on attachment 9036423 [details] [diff] [review]
1519972-folderPane-toolbar-brighttext.patch

Review of attachment 9036423 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/messenger.xul
@@ +454,5 @@
>                <sidebarheader id="folderPaneHeader" hidden="true" align="center"/>
> +              <toolbox id="folderPane-toolbox">
> +                <toolbar id="folderPane-toolbar"
> +                         class="inline-toolbar"
> +                         toolboxid="mail-toolbox"

Should the toolboxid match the id of the parent toolbox in this case? I'm not sure what effect it has: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Property/toolboxid

When I change it to toolboxid="folderPane-toolbox" the folderpane-mode-selector-menulist is no more shown and I can't place buttons etc. on this toolbar.

Comment on attachment 9036423 [details] [diff] [review]
1519972-folderPane-toolbar-brighttext.patch

Review of attachment 9036423 [details] [diff] [review]:
-----------------------------------------------------------------

OK, maybe because that element is part of the palette in mail-toolbox.
Attachment #9036423 - Flags: review?(acelists) → review+

Thanks

Keywords: checkin-needed

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/10e4790e1368
Apply the [brighttext] attribute to the folderPane-toolbar too. r=aceman

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0
You need to log in before you can comment on or make changes to this bug.