1519995 - Convert graphs view to React

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P2)

Description

[Sarah Clements [:sclements]]

This includes the graphsctrl.html partial and the GraphsCtrl controller. The jquery graph functionality can be isolated into a separate component to be replaced at a later point.

The modal should probably be tackled first - filed in bug 1519991.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5096

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5158

Comment 3

[Sarah Clements [:sclements]]

Hi Ionut, I have another pr for the second part of the conversion. Can you test it out on prototype?

Comment 4

[Ionuț Goldan [:igoldan]]

(In reply to Sarah Clements [:sclements] from comment #3)

Hi Ionut, I have another pr for the second part of the conversion. Can you test it out on prototype?

Hi Sarah. I made a quick test on the PR.
I believe I've encountered 2 small bugs. The URL I've used is this one.

#1 Wrong (higher is better) on popups
STR

1. Click a random data point

Expected:
Dark popup should show (lower is better), next to the numerical value.

What we get instead:
(higher is better)

#2 revision to highlight input fields misbehave
STR

1. Randomly select mozilla-inbound data point
2. Copy the short commit hash associated with it.
3. Paste it in one of revision to highlight input fields.

Expected:
Data point gets highlighted.

What we get instead:
Most of the times, no data point from mozilla-inbound gets highlighted. Only those from autoland which have the same commit hash.

Comment 5

[Sarah Clements [:sclements]]

(In reply to Ionuț Goldan [:igoldan], Performance Sheriff from comment #4)

(In reply to Sarah Clements [:sclements] from comment #3)

Hi Ionut, I have another pr for the second part of the conversion. Can you test it out on prototype?

Hi Sarah. I made a quick test on the PR.

Thanks Ionut. I didn't change anything having to do with the tooltips in this pr, so that might be preexisting. I'll check for these two bugs while working on the graphs conversion pr (I've decided to hold off on merging until that pr is complete).

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5286

Comment 7

[Sarah Clements [:sclements]]

Merged https://github.com/mozilla/treeherder/commit/47b53c157ad5a1c496aa765c4a9c6cc7d3fdb9ae