Closed Bug 1520103 Opened 8 months ago Closed 7 months ago

Fix non-unified build in tools/profiler

Categories

(Core :: Gecko Profiler, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox66 --- wontfix
firefox67 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

Details

Attachments

(2 files)

Trying to build in non-unified mode produces a lot of errors, mostly due to missing #include's, but I noticed a few more serious issues (though nothing buggy I think).

On top of making things cleaner, this helps with future file changes, which may be needed for bug 1492121.

Blocks: 1520104

Found when forcing a non-unified build of the Gecko Profiler:

  • "nsError.h" needed to define nsresult.
  • "nsStringFwd.h" needed to declare nsAString and nsACString.

Found issues by forcing a local non-unified build.

Also sorted #includes by logical groups (from most local to most global), and
alphabetically within groups.

Depends on D18621

Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ec4da862bdc
Added missing includes in nsNativeCharsetUtils.h - r=froydnj
https://hg.mozilla.org/integration/autoland/rev/58654f30db8e
Fixed non-unified Profiler build - r=mstange
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Regressions: 1549232
No longer regressions: 1549232
You need to log in before you can comment on or make changes to this bug.