1520103 - Fix non-unified build in tools/profiler

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Trying to build in non-unified mode produces a lot of errors, mostly due to missing #include's, but I noticed a few more serious issues (though nothing buggy I think).

On top of making things cleaner, this helps with future file changes, which may be needed for bug 1492121.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1520103 - Added missing includes in nsNativeCharsetUtils.h - r?froydnj

Found when forcing a non-unified build of the Gecko Profiler:

• "nsError.h" needed to define nsresult.
• "nsStringFwd.h" needed to declare nsAString and nsACString.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1520103 - Fixed non-unified Profiler build - r?mstange

Found issues by forcing a local non-unified build.

Also sorted #includes by logical groups (from most local to most global), and
alphabetically within groups.

Depends on D18621

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Try with non-unified build:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=0d8e191eb11320224927e6619f38ac60e40148da

Try with unified build:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=084737f8fd91e085b6625be0c9f0c0c42ca44144

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ec4da862bdc
Added missing includes in nsNativeCharsetUtils.h - r=froydnj
https://hg.mozilla.org/integration/autoland/rev/58654f30db8e
Fixed non-unified Profiler build - r=mstange

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/8ec4da862bdc
https://hg.mozilla.org/mozilla-central/rev/58654f30db8e