1520104 - Use non-XPCOM/libxul data structures in profiler core

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P3)

Description

[Gerald Squelart (he/him)]

The profiler makes heavy use of nsTArrays and nsXHashtables, which come in the XUL library.
In order to implement bug 1492121 (start profiler before XUL) we need to use data structures that are no dependent on XUL.

nsTArrays could be replaced with Vector and nsXHashtables with Hashmap, both are in mfbt in the mozglue library, which is the very first one to be fully loaded at startup. (Or should I use std:: structs?)

There may be more changes needed, as I progress through this, e.g., ns[C]Strings will probably have to go too.

Comment 1

[Gerald Squelart (he/him)]

By "XUL" I really meant "libxul".

Comment 2

[Gerald Squelart (he/him)]

Attachment: Bug 1520104 - Fix profiler non-unified build - r?mstange

Comment 3

[Gerald Squelart (he/him)]

Attachment: Bug 1520104 - Using Vector instead of nsTArray - r?mstange

Moving to non-XPCOM data structures, to help with upcoming transfer to mozglue.

Depends on D24696

Comment 4

[Gerald Squelart (he/him)]

Attachment: Bug 1520104 - Using Hashmap instead of nsXHashTable - r?mstange

Moving to non-XPCOM data structures, to help with upcoming transfer to mozglue.

Depends on D24697

Comment 5

[Release mgmt bot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:gerald, could you have a look please?

Comment 6

[Gerald Squelart (he/him)]

I want to make sure some follow-up work will in fact happen (working on some roadblocks at the moment) before landing this first piece, as it wouldn't be useful on its own.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37ac8c86f3c7
Fix profiler non-unified build - r=mstange
https://hg.mozilla.org/integration/autoland/rev/97e259a4216f
Using Vector instead of nsTArray - r=mstange
https://hg.mozilla.org/integration/autoland/rev/85c36e78141e
Using Hashmap instead of nsXHashTable - r=mstange

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/37ac8c86f3c7
https://hg.mozilla.org/mozilla-central/rev/97e259a4216f
https://hg.mozilla.org/mozilla-central/rev/85c36e78141e