Closed Bug 1520139 Opened 5 years ago Closed 5 years ago

Android build bustages on nsXREDirProvider fatal error: 'commonupdatedir.h' file not found when Gecko 66 merges to Beta on 2019-01-21

Categories

(Toolkit :: Startup and Profile System, defect)

defect
Not set
major

Tracking

()

VERIFIED FIXED
mozilla66
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 --- unaffected
firefox66 blocking fixed

People

(Reporter: CosminS, Assigned: mossop)

References

Details

(Keywords: regression)

Attachments

(2 files)

[Tracking Requested - why for this release]:
Central as beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&revision=3408da60c0ed028d3f4c94bbf83d0dcc43d5fe38&searchStr=android

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=221950578&repo=try&lineNumber=29379

[task 2019-01-15T11:39:37.726Z] 11:39:37 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/xre'
[task 2019-01-15T11:39:37.739Z] 11:39:37 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ --target=arm-linux-androideabi -o Unified_cpp_toolkit_xre0.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DPROXY_PRINTING=1 -DOS_POSIX=1 -DOS_LINUX=1 '-DMOZ_APP_NAME="fennec"' '-DMOZ_APP_BASENAME="Fennec"' '-DMOZ_APP_DISPLAYNAME="Firefox Beta"' '-DMOZ_APP_VERSION="66.0"' '-DOS_TARGET="Android"' '-DMOZ_WIDGET_TOOLKIT="android"' '-DANDROID_PACKAGE_NAME="org.mozilla.firefox_beta"' '-DTARGET_OS_ABI="Android_arm-eabi-gcc3"' -DGRE_MILESTONE=66.0 -DAPP_VERSION=66.0 '-DAPP_ID={aa3c5121-dab2-40e2-81ca-7ea25febc110}' -DTOPOBJDIR=/builds/worker/workspace/build/src/obj-firefox -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/toolkit/xre -I/builds/worker/workspace/build/src/obj-firefox/toolkit/xre -I/builds/worker/workspace/build/src/toolkit/components/printingui -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/other-licenses/nsis/Contrib/CityHash/cityhash -I/builds/worker/workspace/build/src/toolkit/components/find -I/builds/worker/workspace/build/src/toolkit/components/printingui/ipc -I/builds/worker/workspace/build/src/toolkit/components/windowwatcher -I/builds/worker/workspace/build/src/toolkit/profile -I/builds/worker/workspace/build/src/config -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/commandhandler -I/builds/worker/workspace/build/src/dom/ipc -I/builds/worker/workspace/build/src/dom/webbrowserpersist -I/builds/worker/workspace/build/src/testing/gtest/mozilla -I/builds/worker/workspace/build/src/toolkit/crashreporter -I/builds/worker/workspace/build/src/xpcom/build -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -isystem /builds/worker/workspace/build/src/android-ndk/sysroot/usr/include/arm-linux-androideabi -isystem /builds/worker/workspace/build/src/android-ndk/sysroot/usr/include -gcc-toolchain /builds/worker/workspace/build/src/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64 -D__ANDROID_API_=16 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-short-enums -fno-exceptions -I/builds/worker/workspace/build/src/android-ndk/sources/cxx-stl/llvm-libc++/include -I/builds/worker/workspace/build/src/android-ndk/sources/android/support/include -I/builds/worker/workspace/build/src/android-ndk/sources/cxx-stl/llvm-libc++abi/include -march=armv7-a -mthumb -mfpu=neon -mfloat-abi=softfp -mno-unaligned-access -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -Oz -mno-outline -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/workspace/build/src/obj-firefox/dist/include/cairo -Wno-error=shadow -MD -MP -MF .deps/Unified_cpp_toolkit_xre0.o.pp /builds/worker/workspace/build/src/obj-firefox/toolkit/xre/Unified_cpp_toolkit_xre0.cpp
[task 2019-01-15T11:39:37.739Z] 11:39:37 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/toolkit/xre/Unified_cpp_toolkit_xre0.cpp:119:
[task 2019-01-15T11:39:37.739Z] 11:39:37 INFO - /builds/worker/workspace/build/src/toolkit/xre/nsXREDirProvider.cpp:22:10: fatal error: 'commonupdatedir.h' file not found
[task 2019-01-15T11:39:37.739Z] 11:39:37 INFO - #include "commonupdatedir.h"
[task 2019-01-15T11:39:37.739Z] 11:39:37 INFO - ^~~~~~~~~~~~~~~~~~~
[task 2019-01-15T11:39:37.740Z] 11:39:37 INFO - 1 error generated.
[task 2019-01-15T11:39:37.741Z] 11:39:37 INFO - /builds/worker/workspace/build/src/config/rules.mk:1110: recipe for target 'Unified_cpp_toolkit_xre0.o' failed
[task 2019-01-15T11:39:37.742Z] 11:39:37 ERROR - make[4]: *** [Unified_cpp_toolkit_xre0.o] Error 1
[task 2019-01-15T11:39:37.742Z] 11:39:37 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/xre'
[task 2019-01-15T11:39:37.743Z] 11:39:37 INFO - make[4]: *** Waiting for unfinished jobs....
[task 2019-01-15T11:39:37.743Z] 11:39:37 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/security/nss/lib/ssl/ssl_ssl'
[task 2019-01-15T11:39:37.744Z] 11:39:37 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/security/nss/lib/ssl/ssl_ssl'

This is a regression from Bug 1518587. Dave please have a look. Thank you.

Flags: needinfo?(dtownsend)

This is a simple reverse patch for bug 1518587 which helped me get a successful Firefox for Android build - see bug 1518587 comment 4

probably all you need was -#include "commonupdatedir.h" which for me, on x86_64 worked well - compiled&installed firefox now.

Blocks: 1520190
Blocks: 1520131
When the updater is disabled toolkit/mozapps/update/common is not traversed as
part of the build. But toolkit/mozapps/update/common/commonupdatedir.cpp is
included in the toolkit/xre build regardless and GetInstallHash is used. This
makes nsXREDirProvider.cpp able to find the header that defines it.
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81873890e8b7
Make sure nsXREDirProvider can find commonupdatedir.h regardless of whether the updater is enabled. r=froydnj

Tracking just to make sure this lands before the merge.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Assignee: nobody → dtownsend
Severity: normal → major
Flags: needinfo?(dtownsend)

Please specify a root cause for this bug. See :tmaity for more information.

Root Cause: --- → ?
Root Cause: ? → Coding: Syntax Error
You need to log in before you can comment on or make changes to this bug.