Nightly: broken images for extensions without icons on 'Manage Extension Shortcuts'

VERIFIED FIXED in Firefox 66

Status

VERIFIED FIXED
2 months ago
2 months ago

People

(Reporter: quasicomputational, Assigned: mstriemer)

Tracking

66 Branch
mozilla66

Firefox Tracking Flags

(firefox66 verified)

Details

Attachments

(3 attachments)

(Reporter)

Description

2 months ago

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

Install an add-on without an icon.

Go to about:addons and click 'keyboard shortcuts'.

Actual results:

The add-ons without icons have a 'broken image' icon.

Expected results:

Either no icon at all or the puzzle piece icon (as used on about:addons).

(Reporter)

Comment 1

2 months ago

This is fallout from bug 1303384.

Flags: needinfo?(mstriemer)
Component: Untriaged → Frontend
Product: Firefox → WebExtensions
(Assignee)

Updated

2 months ago
Assignee: nobody → mstriemer
Blocks: 1303384
Flags: needinfo?(mstriemer)
(Assignee)

Updated

2 months ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Comment 3

2 months ago
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c7f31b684841
Include a fallback icon for extension shortcuts r=aswan

Comment 4

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

Comment 5

2 months ago
Posted image 1520164.gif

I tested on Firefox 66.0a1(20190117095319) under Win 7 64-bit and Mac OS X 10.14.1

Mark, is this the expected outcome?

Please see the attached video.

Flags: needinfo?(mstriemer)
(Assignee)

Comment 6

2 months ago

This is what I see for my Nightly from today: https://www.dropbox.com/s/izwv4rosizrzeqv/Screenshot%202019-01-17%2011.45.55.png?dl=0.

What extension are you testing with?

Flags: needinfo?(mstriemer) → needinfo?(cbadescu)

Comment 7

2 months ago
Posted image Bug1520164-2.png

I tested again on Firefox 66.0a1(20190114215201) under Win 7 64-bit and Mac OS X 10.14.1 and I can reproduce the issue.

This issue is verified as fixed on Firefox 66.0a1(20190117215514) under Win 7 64-bit and Mac OS X 10.14.1

  • The extension that I used in my last comment had "icons": {"48": "icons/icon-48.png"}, in manifest.json and no files in the folder “icons”, this is why the ‘broken image’ icon was displayed.

  • The extension that I used for testing has no “icons” declared in the manifest.json file.

Flags: needinfo?(cbadescu)

Updated

2 months ago
Status: RESOLVED → VERIFIED
status-firefox66: fixed → verified
You need to log in before you can comment on or make changes to this bug.