WebRender fails with --enable-warnings-as-errors using Rust 1.33

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: jbeich, Assigned: jrmuizel)

Tracking

60 Branch
mozilla66
Points:
---

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox64 unaffected, firefox65 unaffected, firefox66 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

5 months ago

After bug 1513009 and https://github.com/rust-lang/rust/pull/57387 build fails.

$ rustc -vV
rustc 1.33.0-nightly
binary: rustc
commit-hash: 03acbd71c977
commit-date: 2019-01-14
host: x86_64-unknown-freebsd
release: 1.33.0-nightly
LLVM version: 8.0

$ echo "ac_add_options --enable-warnings-as-errors # mimic MOZ_AUTOMATION" >>.mozconfig
$ ./mach build
[...]
error: static variable func should have an upper case name
--> gfx/wr/webrender/src/platform/unix/font.rs:89:28
|
89 | static ref func: unsafe extern "C" fn($($arg_type),*) -> FT_Error = {
| ^^^^ help: convert the identifier to upper case: FUNC
...
108 | ft_dyn_fn!(FT_Get_MM_Var(face: FT_Face, desc: *mut *mut FT_MM_Var) -> FT_Error);
| -------------------------------------------------------------------------------- in this macro invocation
|
= note: -D non-upper-case-globals implied by -D warnings

error: static variable func should have an upper case name
--> gfx/wr/webrender/src/platform/unix/font.rs:89:28
|
89 | static ref func: unsafe extern "C" fn($($arg_type),*) -> FT_Error = {
| ^^^^ help: convert the identifier to upper case: FUNC
...
109 | ft_dyn_fn!(FT_Done_MM_Var(library: FT_Library, desc: *mut FT_MM_Var) -> FT_Error);
| ---------------------------------------------------------------------------------- in this macro invocation

error: static variable func should have an upper case name
--> gfx/wr/webrender/src/platform/unix/font.rs:89:28
|
89 | static ref func: unsafe extern "C" fn($($arg_type),*) -> FT_Error = {
| ^^^^ help: convert the identifier to upper case: FUNC
...
110 | ft_dyn_fn!(FT_Set_Var_Design_Coordinates(face: FT_Face, num_vals: FT_UInt, vals: *mut FT_Fixed) -> FT_Error);
| ------------------------------------------------------------------------------------------------------------- in this macro invocation

error: aborting due to 3 previous errors
error: Could not compile webrender.

Reporter

Comment 2

5 months ago

Comment on attachment 9036606 [details]
Bug 1520188. Use uppercase for func name.

Thanks, this unbrek my build.

Attachment #9036606 - Flags: feedback+

Comment 3

5 months ago
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3965ba4c93b0
Use uppercase for func name. r=lsalzman

Comment 4

5 months ago
bugherder
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Assignee: nobody → jmuizelaar
You need to log in before you can comment on or make changes to this bug.