Closed Bug 1520189 Opened 3 years ago Closed 3 years ago

Remove the ToWindowProxyIfWindow call in LexicalEnvironmentObject::thisValue

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

We need it because the WindowProxy is attached to the global after the global and its lexical environment are created, but it's nicer to handle this in SetWindowProxy instead.

Then we can trivially inline the slot load in JIT code, and it's also more efficient.

This simplifies LexicalEnvironmentObject::thisValue so it's easier to inline in JIT code.
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/070316635c49
Remove the ToWindowProxyIfWindow call in LexicalEnvironmentObject::thisValue; handle this in js::SetWindowProxy instead. r=luke
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.