Closed Bug 1520191 Opened 1 year ago Closed 1 year ago

[remote-dbg-next] Polish style for error and warning messages

Categories

(DevTools :: about:debugging, enhancement, P1)

enhancement

Tracking

(firefox69 fixed)

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: jdescottes, Assigned: ogasidlo)

References

(Blocks 1 open bug)

Details

(Whiteboard: high-priority-reserve )

Attachments

(3 files)

We already display error messages when temporary addons fail to install. After Bug 1500374 we will also show warning messages if an addon has warnings (for instance unsupported properties in manifest.json).

So far, I am following the guidelines at:

We should still check the fonts, and probably get the correct photon icon for errors.

Priority: -- → P2

To add a bit more context, here is a doc with screenshots to show a bit of the thinking process and the current state:
https://docs.google.com/document/d/1h1aPq7UrHn-NQkhFnlHcfqyOi48M38UqxzEebSXmwzI/edit#heading=h.mdjpskyqhvvh

Please feel free to reach out, if you'd like more context or have additional questions Matt!

For reference, some warnings for addons can really have a lot of text! our options here would be either:

  • crop
  • make the message scrollable
  • add a collapsible container to the error

Thanks for filing this Julian! :)

My suggestion would be to use <details>.

E.g.

<details>
    <summary>Log</summary>
    Error message details
</details>

Moving this to a regular non-ux bug and moving back to P3.

In the short term the goal of this bug should be to:

  • add the appropriate icon for error messages
  • handle long error messages for addon errors, see comment 3

Other improvements related to messages:

  • links in warning messages should be buttons bug 1523295
  • messages should have an X button to dismiss them (follow up to 1520142)
Priority: P2 → P3
Summary: [remote-dbg-next] UX: Style for error and warning messages → [remote-dbg-next] Polish style for error and warning messages
Whiteboard: high-priority-reserve
Assignee: nobody → ogasidlo
Status: NEW → ASSIGNED
Priority: P3 → P1

The icon I used is Identity Icon Hover rotated 180° that you can find here https://design.firefox.com/icons/viewer/#

Is the design shown in the screenshot what we want to achieve?

Flags: needinfo?(jdescottes)

This looks good to me, thanks Ola.

Flags: needinfo?(jdescottes)
Pushed by ogasidlo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28504d015b50
Polish style for error and warning messages r=jdescottes,ladybenko,flod
Attachment #9064706 - Attachment description: Bug #1520191 - Polish style for error and warning messages → Bug 1520191 - Polish style for error and warning messages
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.