Closed
Bug 1520228
Opened 5 years ago
Closed 5 years ago
Provide better error message when EventTarget is not implemented by ActorChild
Categories
(Toolkit :: Async Tooling, defect)
Toolkit
Async Tooling
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
Attachments
(1 file)
When an ActorChild is predefined to listen for DOM events and it
does not implement EventTarget.handleEvent(), a standard JS error
is thrown in toolkit/modules/ActorManagerChild.jsm that the handleEvent
property is missing.
If you have more than one ActorChild this error message is cryptic
as it does not refer to which of the children that is missing
handleEvent.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
When an ActorChild is predefined to listen for DOM events and it does not implement EventTarget.handleEvent(), a standard JS error is thrown in toolkit/modules/ActorManagerChild.jsm that the handleEvent property is missing. If you have more than one ActorChild this error message is cryptic as it does not refer to _which_ of the children that is missing handleEvent. This patch introduces a type check for handleEvent that throws an error (as before) when it is not implemented.
Assignee | ||
Comment 2•5 years ago
|
||
This is one possible implementation. Let me know if you want me
to change it!
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6fa82f19a6d7 toolkit: improve error description when ActorChild is missing EventTarget; r=Felipe
Comment 4•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•