Closed Bug 1520241 Opened 11 months ago Closed 11 months ago

TestSPSCQueue.exe is very slow on Windows

Categories

(Core :: MFBT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

Details

Attachments

(1 file)

The cppunittest TestSPSCQueue.exe takes so long on my Windows machines that it times out. This is because there are nested loops trying to sleep for 10 microseconds, but Windows's default timer resolution turns each one into a 16ms sleep.

Apparently the automation machines have their system timer resolution set to 1ms, which makes the test take "only" 2.5 mins. I can get the same effect on my machines by adding timeBeginPeriod(1) (a trick we use in the profiler and elsewhere), but talking to padenot, that's still too long for this test. Let's just Sleep(0) and hope for the best.

Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5876723df7ba
Avoid slow sleeps on Windows in TestSPSCQueue.exe r=padenot
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Assignee: nobody → dmajor
See Also: → 1546012
You need to log in before you can comment on or make changes to this bug.