Comment on attachment 9043395 [details]
Bug 1520258 - Adding spoc frequency caps based on visibility
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
User impact if declined
We will not be able to cap sponsored content ("SPOCs") to a maximum number of impressions during the Pocket experiment, thus making it very difficult to get valid/comparable data to existing implementations and our expectations of sponsored content performance. This is critical for Pocket's 2019 revenue goals.
Is this code covered by automated tests?
Has the fix been verified in Nightly?
Needs manual test from QE?
If yes, steps to reproduce
See https://bugzilla.mozilla.org/show_bug.cgi?id=1520258#c6. The team is also working on a holistic test plan covering sponsored content and caching for end of day Feb 15th.
List of other uplifts needed
Risk to taking this patch
Why is the change risky/not risky? (and alternatives if risky)
There is a significant amount of functionality being added here, but it is considered critical enough for product to accept the risk.
The risk is mitigated by: isolating the implementation from production code; doing additional manual QA.
String changes made/needed