Collect *_KBREAD_PER_CONN on release as well

RESOLVED FIXED in Firefox 65

Status

()

defect
P2
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: dragana, Assigned: dragana)

Tracking

Trunk
mozilla66
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox65 fixed, firefox66 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(2 attachments)

Assignee

Description

4 months ago
No description provided.
Assignee

Comment 2

4 months ago
Posted file request.txt
Attachment #9036751 - Flags: review?(chutten)

Comment 3

4 months ago

Comment on attachment 9036751 [details]
request.txt

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. These collections are Telemetry so are documented in their definitions file (Histograms.json), the Probe Dictionary, and on telemetry.mozilla.org's Measurement Dashboards.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. These collections are Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes. :dragana is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on, all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. These collections are permanent.


Result: datareview+

Attachment #9036751 - Flags: review?(chutten) → review+
Assignee

Updated

4 months ago
Keywords: checkin-needed
Assignee

Comment 4

4 months ago

Comment on attachment 9036746 [details]
Bug 1520260 - Collect *_KBREAD_PER_CONN on release as well. r=valentin

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: This is only turning on 2 telemetry probes on release. We need this probes for some analysis and would like to have release data from the next release.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): The patch only changes telemetry specification for 2 probe. It is not risky.

String changes made/needed: no

Attachment #9036746 - Flags: approval-mozilla-beta?

Dragana is this for beta only or you need the patch to land also on autoland/inbound?

Flags: needinfo?(dd.mozilla)
Assignee

Comment 6

4 months ago

(In reply to Cosmin Sabou [:CosminS] from comment #5)

Dragana is this for beta only or you need the patch to land also on autoland/inbound?

I need it on autoland/inbound as well.

Flags: needinfo?(dd.mozilla)

Comment 7

4 months ago

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/317bb711eb47
Collect *_KBREAD_PER_CONN on release as well. r=valentin

Keywords: checkin-needed

Comment 8

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

Comment on attachment 9036746 [details]
Bug 1520260 - Collect *_KBREAD_PER_CONN on release as well. r=valentin

[Triage Comment]
Adds some updated Telemetry probes needed by the Necko team. Approved for 65.0b12.

Attachment #9036746 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.