Open
Bug 1520316
Opened 5 years ago
Updated 10 months ago
Unnecessary construction & destruction of <popupnotification>s and children
Categories
(Toolkit :: PopupNotifications and Notification Bars, enhancement, P3)
Toolkit
PopupNotifications and Notification Bars
Tracking
()
NEW
People
(Reporter: timdream, Unassigned)
References
Details
Bug 823443 is implemented in a way that it will pick up the <popupnotification>
s constructed in the mark-up from popup-notifications.inc
, remove it from the DOM tree from browser.xul
, and re-append it when necessary.
This causes the XBL bindings to construct-destruct immediately when the popup up is first shown. With the bindings migrated away from bindings to custom elements, we will be doing useless construction during startup.
The dirtiest way to fix this would be trying to construct the elements from markup lazily later, with MozXULElement.parseXULToFragment()
. I don't know if we want/need to do that or not. I've got a talos push in bug 1518932 just to make sure this will not be a dependency of that bug 🤞🤞🤞.
Updated•5 years ago
|
Component: General → Notifications and Alerts
Updated•5 years ago
|
Priority: -- → P3
Updated•2 years ago
|
Severity: normal → S3
Updated•10 months ago
|
Component: Notifications and Alerts → PopupNotifications and Notification Bars
You need to log in
before you can comment on or make changes to this bug.
Description
•