BrowserSearch.recordOneoffSearchInTelemetry has an unused parameter "where"

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P1
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
Firefox 66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

BrowserSearch.recordOneoffSearchInTelemetry currently takes a "where" parameter, but this is unused:

https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/browser/base/content/browser.js#4161-4168

Removing this, would allow clarifying and simplifying some of the functions in the call tree, and make it easier to port across some of the functionality in bug 1512654 for QuantumBar.

As far as I can tell, the where parameter was last used for "Browser UI Telemetry" which is gone now, and I think we're safe to drop it.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2fc4ce319e74
Removed unused 'where' parameter from BrowserSearch.recordOneoffSearchInTelemetry. r=adw
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.