1520342 - QueryContext.autofill is variously spelled autofill and autoFill

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Drew Willcoxon :adw]

In UrlbarProviderUnifiedComplete.jsm, context.autofill is spelled with a lowercase F, but everywhere else (the controller mostly), it's spelled with an uppercase F.

We should use a lowercase F since as far as I've seen, that's how we spell it nowadays. The pref name uses an uppercase F, which is too bad, but we shouldn't worry about changing it.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1520342 - Fix autofill and autoFill inconsistency by standardizing on autofill (lowercase F).

Comment 2

[Drew Willcoxon :adw]

One related thing is that inside UrlbarController, context.autofill is set like this:

queryContext.autofill = UrlbarPrefs.get("autoFill");

i.e., it means whether autofill is enabled.

But in UrlbarProviderUnifiedComplete, it's set if the first result is an autofill result.

So there's a disconnect in what this property means. The rst doc says it's "whether the first match is an autofill match", and I think clearly that's what it should mean, not whether autofill is enabled.

I'd like to fix this in a new bug though, and the patch here just renames its current usage in the controller.

Comment 3

[Marco Bonardo [:mak]]

(In reply to Drew Willcoxon :adw from comment #2)

One related thing is that inside UrlbarController, context.autofill is set like this:

queryContext.autofill = UrlbarPrefs.get("autoFill");

i.e., it means whether autofill is enabled.

But in UrlbarProviderUnifiedComplete, it's set if the first result is an autofill result.

Yeah, this is wrong, it looks like we ended up using the same property, please file a bug if you didn't yet.

Comment 4

[Drew Willcoxon :adw]

Bug 1520368, sorry, meant to note it here earlier

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af8ebdf790ba
Fix autofill and autoFill inconsistency by standardizing on autofill (lowercase F). r=mak

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/af8ebdf790ba