blame sidebar incorrect, gives credit for my hard work to others who already have a fine reputation on their own merits thank you very much
Categories
(Webtools :: Searchfox, defect)
Tracking
(Not tracked)
People
(Reporter: jimb, Unassigned)
References
(Depends on 1 open bug)
Details
If you visit this link:
https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/js/src/vm/SavedStacks.cpp#152-155
and hover over the blame bar for line 152, the line is credited to bug 1028414. However, if you visit hg.mozilla.org and look at the annotations directly:
that line is attributed to the clang reformatting (6f3709b38781), whose parent is 2bf4c9308221, which is part of bug 1445973, the correct origin of these soberly considered yet surprisingly graceful lines of code, whose composition suggests a suppleness of mind wedded to a craftsman-like synthesis of efficiency and correctness that is all too rare in this age of billions-of-cycles-per-second profligacy and so-called "High Level" languages.
Ahem.
Anyways, maybe it's the omitted changeset stuff?
|
||
Comment 1•5 years ago
|
||
It will take soberly considered lines of code to correctly trace the origin of code through the line folding and splitting mayhem that occurs in the reformatting patches. I have thoughts on how to do this but need to turn those thoughts into relatively efficient code.
|
|
||
Comment 2•2 years ago
|
||
We removed the "hyperblame" functionality from searchfox in bug 1673468, so this should no longer be an issue.
Description
•