Closed
Bug 1520392
Opened 6 years ago
Closed 6 years ago
Fixup jit-tests marked "slow" (remove expression closure, update to latest APIs, etc)
Categories
(Core :: JavaScript Engine, enhancement, P5)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
Details
Attachments
(5 files)
We still have some expression closures in jit-test.
those tests are marked // |jit-test| slow
, and not executed recently, thus overlooked while removing expression closure.
Assignee | ||
Comment 1•6 years ago
|
||
looks like there are some more issues.
I'll fix them at once here.
Summary: Remove expression closure from jit-tests marked "slow" → Fixup jit-tests marked "slow" (remove expression closure, update to latest APIs, etc)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Depends on D16811
Assignee | ||
Comment 4•6 years ago
|
||
Depends on D16812
Assignee | ||
Comment 5•6 years ago
|
||
Depends on D16813
Assignee | ||
Comment 6•6 years ago
|
||
Depends on D16814
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/66959f0748b4
Part 1: Remove expression closures from slow jit-tests. r=jandem
https://hg.mozilla.org/integration/autoland/rev/d59fd4c39eb9
Part 2: Fix cookie in slow jit-test. r=jandem
https://hg.mozilla.org/integration/autoland/rev/25692599e832
Part 3: Add missing error cookie to slow jit-test. r=jandem
https://hg.mozilla.org/integration/autoland/rev/119e9c321200
Part 4: Pass {newCompartment: true} to newGlobal in slow jit-test. r=jandem
https://hg.mozilla.org/integration/autoland/rev/3e943d2e39c9
Part 5: Skip slow jit-test which depends on helper threads if helper threads are not available. r=jandem
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/66959f0748b4
https://hg.mozilla.org/mozilla-central/rev/d59fd4c39eb9
https://hg.mozilla.org/mozilla-central/rev/25692599e832
https://hg.mozilla.org/mozilla-central/rev/119e9c321200
https://hg.mozilla.org/mozilla-central/rev/3e943d2e39c9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•