Closed
Bug 1520422
Opened 6 years ago
Closed 6 years ago
Entries API should not use callback inferfaces
Categories
(Core :: DOM: File, enhancement, P3)
Core
DOM: File
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: Ms2ger, Assigned: baku)
References
Details
Attachments
(2 files)
14.18 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
3.28 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
The spec has
callback FileSystemEntryCallback = void (FileSystemEntry entry);
while we have
callback interface FileSystemEntryCallback {
void handleEvent(FileSystemEntry entry);
};
and similar for other callbacks. This should probably be fixed.
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Updated•6 years ago
|
Component: DOM → DOM: File
Assignee | ||
Updated•6 years ago
|
Summary: Blink FileSystem API should not use callback inferfaces → Entries API should not use callback inferfaces
Assignee | ||
Comment 1•6 years ago
|
||
Assignee: nobody → amarchesini
Attachment #9037744 -
Flags: review?(Ms2ger)
Reporter | ||
Comment 2•6 years ago
|
||
Comment on attachment 9037744 [details] [diff] [review]
fileSystem.patch
Review of attachment 9037744 [details] [diff] [review]:
-----------------------------------------------------------------
No tests?
Assignee | ||
Comment 3•6 years ago
|
||
We have several tests for the Entries API and its callbacks:
https://searchfox.org/mozilla-central/source/dom/filesystem/compat/tests
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/entries-api
Do you have any particular test in mind?
Flags: needinfo?(Ms2ger)
Reporter | ||
Comment 4•6 years ago
|
||
Well, one that would fail without the patch and pass with it, as per the usual policy. I'm guessing a situation where you pass { handleEvent: function() {} }
where the callback is expected.
Flags: needinfo?(Ms2ger)
Assignee | ||
Comment 5•6 years ago
|
||
Attachment #9037987 -
Flags: review?(Ms2ger)
Reporter | ||
Comment 6•6 years ago
|
||
Comment on attachment 9037987 [details] [diff] [review]
part 2 - tests
Review of attachment 9037987 [details] [diff] [review]:
-----------------------------------------------------------------
For future reference, "test" always means "wpt" when I say it :)
Attachment #9037987 -
Flags: review?(Ms2ger) → review+
Reporter | ||
Updated•6 years ago
|
Attachment #9037744 -
Flags: review?(Ms2ger) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/914de25ef027
Entries API should not use callback inferfaces, r=Ms2ger
https://hg.mozilla.org/integration/mozilla-inbound/rev/faade3f1fa13
Entries API should not use callback inferfaces - tests, r=Ms2ger
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/914de25ef027
https://hg.mozilla.org/mozilla-central/rev/faade3f1fa13
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Comment 9•6 years ago
|
||
https://hg.mozilla.org/projects/cedar/rev/914de25ef02776554dd747e3cdca24bcf7a805da
Bug 1520422 - Entries API should not use callback inferfaces, r=Ms2ger
https://hg.mozilla.org/projects/cedar/rev/faade3f1fa138c0abe93a88fd738307329b5d9a2
Bug 1520422 - Entries API should not use callback inferfaces - tests, r=Ms2ger
You need to log in
before you can comment on or make changes to this bug.
Description
•