1520422 - Entries API should not use callback inferfaces

Status: RESOLVED FIXED

(Core :: DOM: File, enhancement, P3)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

The spec has

callback FileSystemEntryCallback = void (FileSystemEntry entry);

while we have

callback interface FileSystemEntryCallback {
    void handleEvent(FileSystemEntry entry);
};

and similar for other callbacks. This should probably be fixed.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: fileSystem.patch

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 9037744 [details] [diff] [review]
fileSystem.patch

Review of attachment 9037744 [details] [diff] [review]:
-----------------------------------------------------------------

No tests?

Comment 3

[Andrea Marchesini [:baku]]

We have several tests for the Entries API and its callbacks:

https://searchfox.org/mozilla-central/source/dom/filesystem/compat/tests
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/entries-api

Do you have any particular test in mind?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Well, one that would fail without the patch and pass with it, as per the usual policy. I'm guessing a situation where you pass { handleEvent: function() {} } where the callback is expected.

Comment 5

[Andrea Marchesini [:baku]]

Attachment: part 2 - tests

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 9037987 [details] [diff] [review]
part 2 - tests

Review of attachment 9037987 [details] [diff] [review]:
-----------------------------------------------------------------

For future reference, "test" always means "wpt" when I say it :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/914de25ef027
Entries API should not use callback inferfaces, r=Ms2ger
https://hg.mozilla.org/integration/mozilla-inbound/rev/faade3f1fa13
Entries API should not use callback inferfaces - tests, r=Ms2ger

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/914de25ef027
https://hg.mozilla.org/mozilla-central/rev/faade3f1fa13

Comment 9

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/projects/cedar/rev/914de25ef02776554dd747e3cdca24bcf7a805da
Bug 1520422 - Entries API should not use callback inferfaces, r=Ms2ger

https://hg.mozilla.org/projects/cedar/rev/faade3f1fa138c0abe93a88fd738307329b5d9a2
Bug 1520422 - Entries API should not use callback inferfaces - tests, r=Ms2ger