Entries API should not use callback inferfaces

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: Ms2ger, Assigned: baku)

Tracking

unspecified
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(2 attachments)

The spec has

callback FileSystemEntryCallback = void (FileSystemEntry entry);

while we have

callback interface FileSystemEntryCallback {
    void handleEvent(FileSystemEntry entry);
};

and similar for other callbacks. This should probably be fixed.

Blocks: 1265767
Priority: -- → P3
Component: DOM → DOM: File
Summary: Blink FileSystem API should not use callback inferfaces → Entries API should not use callback inferfaces
Assignee: nobody → amarchesini
Attachment #9037744 - Flags: review?(Ms2ger)
Comment on attachment 9037744 [details] [diff] [review]
fileSystem.patch

Review of attachment 9037744 [details] [diff] [review]:
-----------------------------------------------------------------

No tests?

We have several tests for the Entries API and its callbacks:

https://searchfox.org/mozilla-central/source/dom/filesystem/compat/tests
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/entries-api

Do you have any particular test in mind?

Flags: needinfo?(Ms2ger)

Well, one that would fail without the patch and pass with it, as per the usual policy. I'm guessing a situation where you pass { handleEvent: function() {} } where the callback is expected.

Flags: needinfo?(Ms2ger)
Attachment #9037987 - Flags: review?(Ms2ger)
Comment on attachment 9037987 [details] [diff] [review]
part 2 - tests

Review of attachment 9037987 [details] [diff] [review]:
-----------------------------------------------------------------

For future reference, "test" always means "wpt" when I say it :)
Attachment #9037987 - Flags: review?(Ms2ger) → review+
Attachment #9037744 - Flags: review?(Ms2ger) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/914de25ef027
Entries API should not use callback inferfaces, r=Ms2ger
https://hg.mozilla.org/integration/mozilla-inbound/rev/faade3f1fa13
Entries API should not use callback inferfaces - tests, r=Ms2ger
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.