Closed Bug 1520447 Opened 10 months ago Closed 9 months ago

For raptor tp6 on windows use mitmproxy executable instead of creating a separate python environment

Categories

(Testing :: Raptor, enhancement, P1)

Version 3
enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: Bebe, Assigned: Bebe)

References

Details

Attachments

(1 file)

Mitmproxy provides win executable file now.

https://mitmproxy.org/downloads/#2.0.2/

Update the current setup to use the new executable and remove the python env

Assignee: nobody → fstrugariu

to run this we need mitmproxy 2.0.2 to be available in tooltool
https://drive.google.com/open?id=10qyWF-bLGVCik3lwjBXpaa1nq7NZDRia

To test this when running the test on win please copy the above file to obj-****/testing/raptor

The mitmproxy file was downloaded from:
https://mitmproxy.org/downloads/#2.0.2/

:rwood can upload the bin to tool tool?
That would help with the review

Flags: needinfo?(rwood)

(In reply to Florin Strugariu [:Bebe] from comment #4)

:rwood can upload the bin to tool tool?
That would help with the review

Uploaded file (from link in Comment 2) to tooltool; emailed manifest to :bebe.

Flags: needinfo?(rwood)
Priority: -- → P1
Blocks: 1520448
See Also: → 1471919
Depends on: 1524620
Blocks: 1511341

try push
https://treeherder.mozilla.org/#/jobs?repo=try&revision=35552b25c6b510227e4bd093e26a68dbf01edfc3&selectedJob=226504928

Looks like we have some issues when running the tests.
I will tests on a windows machine

did a little bit of research and mozprocess has a class design to handle processes.[1]
Using this we can kill/start the mitmdump process easily

[1]https://searchfox.org/mozilla-central/source/testing/mozharness/mozprocess/processhandler.py#1062

here is the try job
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c599804cd986e79786705d73e2577c19828af3ff

:rwood can you review this change?

Flags: needinfo?(rwood)

(In reply to Florin Strugariu [:Bebe] from comment #8)

did a little bit of research and mozprocess has a class design to handle processes.[1]
Using this we can kill/start the mitmdump process easily

[1]https://searchfox.org/mozilla-central/source/testing/mozharness/mozprocess/processhandler.py#1062

here is the try job
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c599804cd986e79786705d73e2577c19828af3ff

:rwood can you review this change?

I'll have a look at the phabricator review now; please add Raptor tp6 Chromium jobs to your try push ^ thanks!

Flags: needinfo?(rwood) → needinfo?(fstrugariu)

I'll have a look at the phabricator review now; please add Raptor tp6 Chromium jobs to your try push ^ thanks!

Also since this is a fairly big change, along with the Chromium tp6 please add to your try push:

  • at least one Firefox benchmark and one Chromium benchmark job i.e. speedometer

  • at least one Raptor tp6 job with --gecko-profile on

  • run the raptor android power test

Thanks!

I ran all the tests just to make sure it works

We have 3 failures but I don't think they are related to this patch

I used the same try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c599804cd986e79786705d73e2577c19828af3ff

Flags: needinfo?(fstrugariu)
Pushed by fstrugariu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a5ad662d5bbb
For raptor tp6 on windows use mitmproxy executable instead of creating a separate python environment r=rwood,davehunt

Yes I triggered by mistake those jobs.

I was trying to run all raptor jobs to make sure this change works as expected

Flags: needinfo?(fstrugariu)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/00df850ac3cf
For raptor tp6 on windows use mitmproxy executable instead of creating a separate python environment r=rwood,davehunt
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.