Closed Bug 1520464 Opened 9 months ago Closed 9 months ago

Gloda facet bindings can't be loaded.

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 66.0

People

(Reporter: arshad, Assigned: arshad)

References

Details

(Keywords: regression)

Attachments

(1 file)

When a search is made then the gloda facet custom element added in Bug 1515308 cant be loaded as they are missing type attribute. I am not sure why this was not catched when the patch was being reviewed by me.

Summary: Gloda facet bindings can't load. → Gloda facet bindings can't be loaded.
Keywords: regression
Assignee: nobody → arshdkhn1
Status: NEW → ASSIGNED
Attached patch facet-fix.patchSplinter Review
Attachment #9036909 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9036909 [details] [diff] [review]
facet-fix.patch

Review of attachment 9036909 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9036909 - Flags: review?(mkmelin+mozilla) → review+
Blocks: 1515308
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f28d1534be7c
Fix gloda facet custom element loading. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0
You need to log in before you can comment on or make changes to this bug.