Fix facet-discrete animation on including and excluding an item.

RESOLVED FIXED in Thunderbird 66.0

Status

defect
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: arshad, Assigned: arshad)

Tracking

({regression})

Trunk
Thunderbird 66.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

No description provided.
Assignee: nobody → arshdkhn1
Status: NEW → ASSIGNED
Keywords: regression

The first include and exclude is normal, but any include/exclude after that doesn't end up in the right way.

Attachment #9036933 - Flags: review?(mkmelin+mozilla)
Attachment #9036933 - Attachment is obsolete: true
Attachment #9036933 - Flags: review?(mkmelin+mozilla)
Attachment #9036944 - Attachment is obsolete: true
Attachment #9036948 - Flags: review?(mkmelin+mozilla)

Apply this patch on top of patch from Bug 1520464.

Attachment #9036948 - Flags: review?(mkmelin+mozilla) → review?(jorgk)
Comment on attachment 9036948 [details] [diff] [review]
facet-discrete-animation.patch

I'm trying to keep out of de-XBL and friends.

Comment should be:
  // Adding setTimeout to improve the facet-discrete animation.
  // See Bug 1439323 for more detail.
Attachment #9036948 - Flags: review?(jorgk) → review?(mkmelin+mozilla)

(In reply to Jorg K (GMT+1) from comment #6)

Comment on attachment 9036948 [details] [diff] [review]
facet-discrete-animation.patch

I'm trying to keep out of de-XBL and friends.

Comment should be:
// Adding setTimeout to improve the facet-discrete animation.
// See Bug 1439323 for more detail.

Well it was just a timeout that tries to fix the racing condition.

Attachment #9036948 - Attachment is obsolete: true
Attachment #9036948 - Flags: review?(mkmelin+mozilla)
Attachment #9037766 - Flags: review?(mkmelin+mozilla)
Attachment #9037766 - Attachment is obsolete: true
Attachment #9037766 - Flags: review?(mkmelin+mozilla)
Duplicate of this bug: 1439323
Attachment #9037767 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9037767 [details] [diff] [review]
facet-discrete-animation.patch

Review of attachment 9037767 [details] [diff] [review]:
-----------------------------------------------------------------

Usually setTimeout is a hack, and perhaps it is here too. But this is a hack to make the UI look better and shouldn't cause problems elsewhere, so let's take it. r=mkmelin
Attachment #9037767 - Flags: review?(mkmelin+mozilla) → review+

On IRC Arshad told me that he had tried async/await somehow with no success.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9e7712f9a4d2
Fix facet-discrete animation. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Keywords: checkin-needed
Resolution: --- → FIXED

Does this need beta uplift to TB 65 beta? What's the regressing bug?

Target Milestone: --- → Thunderbird 66.0
You need to log in before you can comment on or make changes to this bug.