Fix facet-discrete animation on including and excluding an item.
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
People
(Reporter: arshad, Assigned: arshad)
References
Details
(Keywords: regression)
Attachments
(1 file, 4 obsolete files)
|
1.56 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
The first include and exclude is normal, but any include/exclude after that doesn't end up in the right way.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
Apply this patch on top of patch from Bug 1520464.
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 6•5 years ago
|
||
Comment on attachment 9036948 [details] [diff] [review] facet-discrete-animation.patch I'm trying to keep out of de-XBL and friends. Comment should be: // Adding setTimeout to improve the facet-discrete animation. // See Bug 1439323 for more detail.
|
|
Assignee | |
Comment 7•5 years ago
|
||
(In reply to Jorg K (GMT+1) from comment #6)
Comment on attachment 9036948 [details] [diff] [review]
facet-discrete-animation.patchI'm trying to keep out of de-XBL and friends.
Comment should be:
// Adding setTimeout to improve the facet-discrete animation.
// See Bug 1439323 for more detail.
Well it was just a timeout that tries to fix the racing condition.
|
|
Assignee | |
Comment 8•5 years ago
|
||
|
|
Assignee | |
Comment 9•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 11•5 years ago
|
||
Comment on attachment 9037767 [details] [diff] [review] facet-discrete-animation.patch Review of attachment 9037767 [details] [diff] [review]: ----------------------------------------------------------------- Usually setTimeout is a hack, and perhaps it is here too. But this is a hack to make the UI look better and shouldn't cause problems elsewhere, so let's take it. r=mkmelin
|
|
||
Updated•5 years ago
|
|
|
||
Comment 12•5 years ago
|
||
On IRC Arshad told me that he had tried async/await somehow with no success.
|
||
Comment 13•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9e7712f9a4d2
Fix facet-discrete animation. r=mkmelin
|
|
||
Comment 14•5 years ago
|
||
Does this need beta uplift to TB 65 beta? What's the regressing bug?
Description
•