`mach build -v` should enable verbose cargo logging

RESOLVED FIXED in Firefox 66

Status

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: ted, Assigned: chmanchester)

Tracking

Trunk
mozilla66

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

When invoking mach build -v we currently only toggle whether we invoke make with -s:
https://searchfox.org/mozilla-central/rev/bee8cf15c901b9f4b0c074c9977da4bbebc506e3/python/mozbuild/mozbuild/base.py#650-651

We currently enable verbose cargo logs in automation or when BUILD_VERBOSE_LOG is set:
https://searchfox.org/mozilla-central/rev/bee8cf15c901b9f4b0c074c9977da4bbebc506e3/config/rules.mk#836-842

That variable was added in bug 1262569 as an undocumented way to re-enable logging of source file names during the build.

We should enable cargo's verbose logging when mach build -v is used. The simplest way to do that would be to pass BUILD_VERBOSE_LOG=1 to make.

Assignee

Updated

4 months ago
Assignee: nobody → cmanchester

Comment 2

4 months ago
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/69a1d3aa522d
Set verbose logging for cargo when -v is passed to |./mach build|. r=nalexander

Comment 3

4 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.