1520537 - Perma Windows build bustages build\src\obj-firefox\dist\include\mozilla/NativeNt.h when Gecko 66 merges to Beta on 2019-01-21

Status: VERIFIED FIXED

Description

[Razvan Maries]

[Tracking Requested - why for this release]:

Central as Beta Simulation

Treehedred link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=c0732327e39ba5e2a2ddc9a71bbb6cef6f8c20a9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=222201540&repo=try&lineNumber=33398

This was caused by: Bug 1511078, Bug 1517636, aaron can you please take a look?

Beta Simulation with above bugs backed out: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=b503da16dd4f7b3b64915b60ff05efe11336ef8a

Comment 1

[Aaron Klotz [:aklotz]]

Attachment: Bug 1520537: Always export LauncherResult.h in Windows builds; r?mhowell

Comment 2

[Aaron Klotz [:aklotz]]

Thanks. We should always be exporting LauncherResult, since we still build the launcher process on Windows even when we're not going to use it by default.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef66755764d4
Always export LauncherResult.h in Windows builds; r=mhowell

Comment 4

[Aaron Klotz [:aklotz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c22745602a2664b6c2acc829ad38a1ba28d1860

Comment 5

[Aaron Klotz [:aklotz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=76265d37d1b3b04038f72b4dea707b8599142b8a

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ef66755764d4

Comment 8

[Cristina Coroiu [:ccoroiu]]

This is still failing on today's beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=5ddbc9d1917ef1312bd39b44664a8245500398ae&selectedJob=222443455

:aklotz could you please take a look?

Comment 9

[Aaron Klotz [:aklotz]]

Attachment: Bug 1520537: Clean up use of LauncherRegistryInfo when MOZ_LAUNCHER_PROCESS is not defined; r=mhowell

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fa7cd75df96
Clean up use of LauncherRegistryInfo when MOZ_LAUNCHER_PROCESS is not defined; r=mhowell

Comment 12

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/6fa7cd75df96

Comment 13

[Cosmin Sabou [:CosminS]]

This no longer appears on beta-simulations: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=c1bb637c075dae91ada5786c2c092e9de2da7c5f&searchStr=windows%2C2012&selectedJob=222702766