Closed
Bug 1520645
Opened 6 years ago
Closed 6 years ago
Improve vector recycling to avoid heap allocations
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: kvark, Assigned: kvark)
Details
Attachments
(1 file)
The old vector recycler (see recycle_vec
) had a few problems:
- shrinking to fit would be inevitably followed by re-allocation, since it's unlikely that the consequent sizes are below the immediately followed frames
- shrinking before clearing means that the existing contents are copied over, which is a waste
Assignee | ||
Comment 1•6 years ago
|
||
The old vector recycler had a few problems:
1. shrinking to fit would be inevitably followed by re-allocation, since it's unlikely that the consequent sizes are below the immediately followed frames
2. shrinking before clearing means that the existing contents are copied over, which is a waste
The new code has more complicated logic for recycling, aimed at reducing heap allocations. It's also collecting the statistics.
Pushed by dmalyshau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf95c0c1f962
WR improved vector allocation recycler r=nical
Comment 3•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Updated•6 years ago
|
Assignee: nobody → dmalyshau
You need to log in
before you can comment on or make changes to this bug.
Description
•