1520665 - Replace context.autofill property with autofillValue, and make the UnifiedComplete provider set it based on result.getValueAt()

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Drew Willcoxon :adw]

We were talking about the context.autofill property earlier today, and I realized it should probably be autofillValue instead, a string value. Currently UrlbarMatch doesn't have an obvious way to communicate the value that should be autofilled in the input. For URL matches, the value is payload.url -- actually it's only based on the URL because it probably won't include the scheme for example, or it may not include the "www.". For @search alias matches, the value is "@alias ".

We could add another property to UrlbarMatch for the autofill value, but we already have a context.autofill flag, so it makes more sense to change that to autofillValue.

The autofill value in autocomplete results is always given by result.getValueAt(), so the UnifiedComplete provider should use that to set autofillValue.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1520665 - Replace context.autofill property with autofillValue, and make the UnifiedComplete provider set it based on result.getValueAt()

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4edf77f5ca0
Replace context.autofill property with autofillValue, and make the UnifiedComplete provider set it based on result.getValueAt() r=mak

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f4edf77f5ca0