Closed Bug 1520665 Opened 10 months ago Closed 10 months ago

Replace context.autofill property with autofillValue, and make the UnifiedComplete provider set it based on result.getValueAt()

Categories

(Firefox :: Address Bar, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 66
Tracking Status
firefox66 --- fixed

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(1 file)

We were talking about the context.autofill property earlier today, and I realized it should probably be autofillValue instead, a string value. Currently UrlbarMatch doesn't have an obvious way to communicate the value that should be autofilled in the input. For URL matches, the value is payload.url -- actually it's only based on the URL because it probably won't include the scheme for example, or it may not include the "www.". For @search alias matches, the value is "@alias ".

We could add another property to UrlbarMatch for the autofill value, but we already have a context.autofill flag, so it makes more sense to change that to autofillValue.

The autofill value in autocomplete results is always given by result.getValueAt(), so the UnifiedComplete provider should use that to set autofillValue.

Priority: -- → P1
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4edf77f5ca0
Replace context.autofill property with autofillValue, and make the UnifiedComplete provider set it based on result.getValueAt() r=mak
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.