UnifiedComplete should set the default index before adding search @alias autofill matches

RESOLVED FIXED in Firefox 66

Status

()

defect
P1
normal
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: adw, Assigned: adw)

Tracking

unspecified
Firefox 66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

I found this while working on the patch in bug 1520665 (plus more WIP autofill work). When UnifiedComplete adds @alias autofill matches, first it adds the match, and then it calls this._result.setDefaultIndex(0). That means that the quantumbar UnifiedComplete provider doesn't recognize @alias autofill matches because when matches are added, it checks that the default index == 0, but because the default index is set after adding the match in this case, it remains -1.

Every other time UnifiedComplete adds autofill matches, it first sets the default index before adding the match, so this is just an error in UnifiedComplete's adding @alias autofill matches. However, this doesn't seem to actually impact the legacy urlbar and autocomplete controller at all.

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9875054a2a07
Make UnifiedComplete set the default index before adding search @alias autofill matches. r=mak
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.