1520668 - UnifiedComplete should set the default index before adding search @alias autofill matches

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Drew Willcoxon :adw]

I found this while working on the patch in bug 1520665 (plus more WIP autofill work). When UnifiedComplete adds @alias autofill matches, first it adds the match, and then it calls this._result.setDefaultIndex(0). That means that the quantumbar UnifiedComplete provider doesn't recognize @alias autofill matches because when matches are added, it checks that the default index == 0, but because the default index is set after adding the match in this case, it remains -1.

Every other time UnifiedComplete adds autofill matches, it first sets the default index before adding the match, so this is just an error in UnifiedComplete's adding @alias autofill matches. However, this doesn't seem to actually impact the legacy urlbar and autocomplete controller at all.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1520668 - Make UnifiedComplete set the default index before adding search @alias autofill matches.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9875054a2a07
Make UnifiedComplete set the default index before adding search @alias autofill matches. r=mak

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9875054a2a07