Include root content clip rect in picture caching world bounds.

RESOLVED FIXED in Firefox 66

Status

()

RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: gw, Assigned: gw)

Tracking

(Blocks: 1 bug)

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago

Previously, this was calculated per-primitive each time we walked the clip chain.

However, this is wasteful - we know that every primitive will have the same clip at the root of the clip chain.

Instead, transform it to world space once during pre_update, and include that in the primitive bounds.

(Assignee)

Comment 2

2 months ago

This fixes some, but not all, of the reasons that https://bugzilla.mozilla.org/show_bug.cgi?id=1480945 is invalidating picture caches more often than it should.

Assignee: nobody → gwatson
Blocks: 1480945

Comment 3

2 months ago
Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80ea2afaa742
Include root content clip rect in picture caching world bounds. r=kvark

Comment 4

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.