Closed Bug 1520687 Opened 5 years ago Closed 5 years ago

Include root content clip rect in picture caching world bounds.

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: gw, Assigned: gw)

References

Details

Attachments

(1 file)

Previously, this was calculated per-primitive each time we walked the clip chain.

However, this is wasteful - we know that every primitive will have the same clip at the root of the clip chain.

Instead, transform it to world space once during pre_update, and include that in the primitive bounds.

This fixes some, but not all, of the reasons that https://bugzilla.mozilla.org/show_bug.cgi?id=1480945 is invalidating picture caches more often than it should.

Assignee: nobody → gwatson
Blocks: 1480945
Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80ea2afaa742
Include root content clip rect in picture caching world bounds. r=kvark
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: