1520821 - Remove find anonymous element(s) extension commands

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P1)

Description

[James Graham [:jgraham]]

With XBL going away the XBL extensions shouldn't be needed any more. We should remove them. I can't see any usage in mozilla-central or on github.com/mozilla but I wonder if we know of any other out-of-tree users that depend on these extensions?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

What do you mean with XBL extensions in combination with geckodriver?

Comment 2

[Andreas Tolfsen ❲:ato❳]

geckodriver implements XblLocatorParameters as a locator strategy
extension for the element retrieval commands:
https://searchfox.org/mozilla-central/rev/dac799c9f4e9f5f05c1071cba94f2522aa31f7eb/testing/geckodriver/src/command.rs#225-229

Do we know where—if at all!—they are being used?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Oh! Those are meant. Yes, we need them. They are in use at least by FoxPuppet.

To remove those commands we need at least bug 1397874 fixed.

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #3)

Oh! Those are meant. Yes, we need them. They are in use at least by FoxPuppet.

To remove those commands we need at least bug 1397874 fixed.

Does all of XBL need to be removed, or is there a subset of elements / bindings that are blocking this? Also, could you point me to the code that relies on this in FoxPuppet?

Comment 5

[Andreas Tolfsen ❲:ato❳]

+davehunt

I am also curious where we run FoxPuppet tests.

In the FoxPuppet repository I couldn’t find any references to “xbl”
or “anon”, but I may have grepped for the wrong things:
https://github.com/mozilla/FoxPuppet

Comment 6

[James Graham [:jgraham]]

https://github.com/mozilla/FoxPuppet/search?q=anonymous&unscoped_q=anonymous seems to be all the code in FoxPuppet. Looks like it's all about interacting with notifications of various kinds, so removing XBL in those places might be the only blocker.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Again, we don't know of any other external usage of the chrome scoped extension commands.

Comment 8

[Brian Grinstead [:bgrins]]

(In reply to James Graham [:jgraham] from comment #6)

https://github.com/mozilla/FoxPuppet/search?q=anonymous&unscoped_q=anonymous seems to be all the code in FoxPuppet. Looks like it's all about interacting with notifications of various kinds, so removing XBL in those places might be the only blocker.

OK, so those looks like they are working with popup-notifications, which I'm coincidentally currently working on moving away from XBL in Bug 1487065.

Unless if I'm missing something, once that's done we would need to update FoxPuppet to use normal DOM queries, and then this bug could be done.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Not immediately. We also have to keep some kind of backward compatibility. So these commands cannot be removed immediately, but then when we decide to no longer support a specific release of Firefox. Our up-to-date support matrix can be found here:

https://firefox-source-docs.mozilla.org/testing/geckodriver/geckodriver/Support.html

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

To keep backward compatibility for a while we cannot remove those strategies for the next couple of months. Right now our minimum supported Firefox version is 60.0 with the upcoming geckodriver 0.26.0 release.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

James, would you be fine in getting this removed now? We removed the support in Marionette with the 72 release, and this is all related to chrome scope anyway. So web specific tests aren't affected by that. I'm happy to get this removed.

Comment 12

[James Graham [:jgraham]]

Very happy to have these removed.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1520821 - [geckodriver] Remove find anonymous element(s) extension commands.

Support for anonymous elements has been removed in Firefox 72.
Because that support was chrome scope only, it can be safely
removed from geckodriver.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4705f5e9f359
[geckodriver] Remove find anonymous element(s) extension commands. r=webdriver-reviewers,jgraham

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4705f5e9f359