Closed Bug 1520835 Opened 1 year ago Closed 1 year ago

Remove attachConsole/attachThread/attachTarget from DebuggerClient.

Categories

(DevTools :: Framework, enhancement, P2)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(2 files)

All these three methods are mostly used by Target class or target fronts.
Now that they are all merged, it makes sense to move attachConsole and attachThread into base Target class and merge it with already existing ones.
There is also attachTarget which should no longer be used (it is still used by some tests).

https://searchfox.org/mozilla-central/rev/dac799c9f4e9f5f05c1071cba94f2522aa31f7eb/devtools/shared/client/debugger-client.js#339-431

Bug 1485664 (webconsole client to front) is replacing attachConsole by getFront("webconsole"),
while bug 1269919 (stop emitting duplicated newSource) is unifying the various attachThread method onto base Target class.

Depends on: 1485664, 1269919
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b81205ec0a0b
Remove unused attachTarget methods. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/e867319290bb
Removed now-useless front pool from DebuggerClient. r=jdescottes
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.