1520843 - Crash in mozilla::layout::FindScrollAnchoringBoundingRect

Status: RESOLVED WORKSFORME

(Core :: Layout, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-c8b5bc72-a965-4012-a873-dfa280190113.

Seen while looking at nightly crash stats: https://bit.ly/2QWrvZG. Crashes started using 20190112213654. 7 crashes/9 installs so far, across all platforms.

Top 10 frames of crashing thread:

0 xul.dll static struct nsRect mozilla::layout::FindScrollAnchoringBoundingRect layout/generic/ScrollAnchorContainer.cpp:91
1 xul.dll mozilla::layout::ScrollAnchorContainer::ApplyAdjustments layout/generic/ScrollAnchorContainer.cpp:240
2 xul.dll nsContainerFrame::FinishReflowChild layout/generic/nsContainerFrame.cpp:1076
3 xul.dll mozilla::ViewportFrame::Reflow layout/generic/ViewportFrame.cpp:318
4 xul.dll bool mozilla::PresShell::DoReflow layout/base/PresShell.cpp:8601
5 xul.dll mozilla::PresShell::DoFlushPendingNotifications layout/base/PresShell.cpp:4179
6 xul.dll void nsRefreshDriver::Tick layout/base/nsRefreshDriver.cpp:1843
7 xul.dll void mozilla::RefreshDriverTimer::TickRefreshDrivers layout/base/nsRefreshDriver.cpp:305
8 xul.dll void mozilla::RefreshDriverTimer::Tick layout/base/nsRefreshDriver.cpp:321
9 xul.dll void mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver layout/base/nsRefreshDriver.cpp:647

Comment 1

[Jonathan Watt [:jwatt]]

Just flagging this so you're aware of it, Ryan.

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Thanks. It's a weird crash at a low volume. Let's keep an eye on this.

I've experienced some crashes when disabling and enabling scroll anchoring without a restart. The code doesn't handle it well. These crashes might share that cause. I have a patch to fix this, that I'll put up soon.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Do you have the bug number where you're working on that patch? Thanks.

Comment 4

[Ryan Hunt [:rhunt] (on leave until early May)]

Apologies, I meant to link them together when I filed it. It's bug 1521278 and has landed.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

OK, I'll check back on this next week and if we don't see any crashes in beta 66 we can probably close the bug.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See How Do You Triage for more information

Comment 7

[Sean Voisen (:svoisen)]

Self-assigning to keep an eye on it. Looks like we haven't had any newer crashes from the spike though.

Comment 8

[Marcia Knous [:marcia]]

Last crash I see was in 20190117095319.

Comment 9

[Marcia Knous [:marcia]]

One lone crash using the build from 2-12.

Comment 10

[Sean Voisen (:svoisen)]

@Liz: You OK closing this one? Looks to have stabilized; no more crashes.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Sounds good. Thanks!