1520853 - update default search shortcuts config for Fx66

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Mike Connor [:mconnor]]

Based on engagement to date, we're going to selectively enable search shortcuts for the current six countries where we've rolled out to date: DE, FR, GB, IT, JP, US

Additionally, I'd like to stop adding the default engines (Google/Yandex/Baidu) since it doesn't seem to be a net positive in broader deployment. This would mean we'd only add Amazon for new users.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4715

Comment 2

[Mike Connor [:mconnor]]

Commented on the PR, let's back up and try again.

Per the discussion earlier, the new default behaviour for Fx66 should be:

• Add Amazon in the following regions: DE, FR, GB, IT, JP, US
• use the search service to determine the current default by identifier
  • Services.search.defaultEngine.identifier will start with:
    • Google: "google"
    • Yandex: "yandex", "yasearch"
    • Baidu: "baidu"
• If the user doesn't have the default engine for their region, add the default for that region.
  • Baidu for China (CN)
  • Yandex for the four Yandex geos (RU, TR, KZ, BY)
  • Google everywhere else

cc-ing Mike Kaply to make sure I'm not forgetting any obvious cases.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/9a2d7c12d7d9fd3f1e3abc0a24df8f34bdaf516e
Bug 1520853 - update default search shortcuts config for Fx66 (#4715)

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

QA Notes:

• See comment 2
• Verify that switching away from the default search engine causes it to appear pinned in the top sites. Does that make sense? For example, in USA on first run I will only see the Amazon shortcut pinned. If I change my default search to Bing, I'll then have the Amazon and Google shortcuts pinned in top sites.

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9d660bf33923

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (66.0b13 Build ID - 20190304101322) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, only the "Amazon" shortcut is displayed however, after changing the default search engine the "Google" shortcut will be also pinned in the "Top Sites" area.