Use the return of Array.concat in exceptionDialog.js

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P1
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

57 Branch
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

Bug 1518786 landed a patch, in which the elements that are having their localization text updated are returned from updateCertStatus(). This result is then concatenated with an array of other elements that are getting updated. However, the result of the call to concat() is ignored and thus the return value is not actually used.

We can also do a little clean-up in the checkCert() function to use await in another place since the function is async and we don't need to use .then().

Priority: -- → P1

Comment 2

3 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/188f7a851811
Use the return value of Array.concat when building the list of nodes that are being localized before window.sizeToContent. r=Gijs

Comment 3

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.