Closed
Bug 1520865
Opened 5 years ago
Closed 5 years ago
Use the return of Array.concat in exceptionDialog.js
Categories
(Core :: Security: PSM, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
References
Details
Attachments
(1 file)
Bug 1518786 landed a patch, in which the elements that are having their localization text updated are returned from updateCertStatus(). This result is then concatenated with an array of other elements that are getting updated. However, the result of the call to concat() is ignored and thus the return value is not actually used.
We can also do a little clean-up in the checkCert() function to use await in another place since the function is async and we don't need to use .then().
|
Assignee | |
Updated•5 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/188f7a851811 Use the return value of Array.concat when building the list of nodes that are being localized before window.sizeToContent. r=Gijs
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•