Closed Bug 1520878 Opened 2 years ago Closed 2 years ago

Process '-e foo' arguments to the JS shell as UTF-8, not Latin-1, and remove JS::EvaluateLatin1 as unused

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

This is the last Latin-1 API in JSAPI.

xpcshell already interprets its -e arguments in this manner. I haven't tryserver'd this to see if everyone's fine with this, but they probably are. If they aren't, well, we can fix them in bugs blocking this one. But I doubt it.

Attached patch PatchSplinter Review
Attachment #9037350 - Flags: review?(jdemooij)
Comment on attachment 9037350 [details] [diff] [review]
Patch

Review of attachment 9037350 [details] [diff] [review]:
-----------------------------------------------------------------

💯💯
Attachment #9037350 - Flags: review?(jdemooij) → review+
Priority: -- → P2
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b120777f7b7d
Process '-e foo' arguments to the JS shell as UTF-8, not Latin-1, in order to remove JS::EvaluateLatin1, the last public Latin-1-consuming compilation API in SpiderMonkey.  r=jandem
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.